[Fwd: [MacPorts Lint] Portfile Lint Errors for: vim]
Hi Bill, I got this error message below. Is there something broken? Or is there anything in my port which could cause such an error? I also got the same error for vim-app. This was sent out after commit r34037. Rainer -------- Original Message -------- Subject: [MacPorts Lint] Portfile Lint Errors for: vim Date: Sun, 10 Feb 2008 16:12:58 -0800 From: noreply@macports.org To: raimue@macports.org, Portfile: vim Errors: can't read "portvariants": no such variable
I actually get 147 warnings now instead of what you got in the email... As far as I know, the linting is working. I dont maintain the lint code, I just maintain the server-side process for making those emails exactly from the output of "port lint". You should get the same errors locally with "port lint" before committing. If you see a discrepancy, definitely forward me the output the server gave you and the output you get locally. -Bill On Feb 10, 2008, at 4:29 PM, Rainer Müller wrote:
Hi Bill,
I got this error message below. Is there something broken? Or is there anything in my port which could cause such an error? I also got the same error for vim-app. This was sent out after commit r34037.
Rainer
-------- Original Message -------- Subject: [MacPorts Lint] Portfile Lint Errors for: vim Date: Sun, 10 Feb 2008 16:12:58 -0800 From: noreply@macports.org To: raimue@macports.org,
Portfile: vim
Errors: can't read "portvariants": no such variable
---- William Siegrist Software Support Engineer Mac OS Forge http://macosforge.org/ wsiegrist@apple.com 408 862 7337
William Siegrist wrote:
I actually get 147 warnings now instead of what you got in the email... As far as I know, the linting is working. I dont maintain the lint code, I just maintain the server-side process for making those emails exactly from the output of "port lint". You should get the same errors locally with "port lint" before committing. If you see a discrepancy, definitely forward me the output the server gave you and the output you get locally.
Yes, locally I also get these 147 warnings and they are "unfixable" (the patches will be downloaded and therefore can't be named differently). But the port lint post-commit hook sent me this error message only. Rainer
I found it. It turns out I was grabbing the port's dir non- recursively, so those extra files/* were not getting included and thats what that cryptic error meant. -Bill On Feb 11, 2008, at 9:39 AM, Rainer Müller wrote:
William Siegrist wrote:
I actually get 147 warnings now instead of what you got in the email... As far as I know, the linting is working. I dont maintain the lint code, I just maintain the server-side process for making those emails exactly from the output of "port lint". You should get the same errors locally with "port lint" before committing. If you see a discrepancy, definitely forward me the output the server gave you and the output you get locally.
Yes, locally I also get these 147 warnings and they are "unfixable" (the patches will be downloaded and therefore can't be named differently). But the port lint post-commit hook sent me this error message only.
Rainer
---- William Siegrist Software Support Engineer Mac OS Forge http://macosforge.org/ wsiegrist@apple.com 408 862 7337
On Feb 11, 2008, at 11:39, Rainer Müller wrote:
William Siegrist wrote:
I actually get 147 warnings now instead of what you got in the email... As far as I know, the linting is working. I dont maintain the lint code, I just maintain the server-side process for making those emails exactly from the output of "port lint". You should get the same errors locally with "port lint" before committing. If you see a discrepancy, definitely forward me the output the server gave you and the output you get locally.
Yes, locally I also get these 147 warnings and they are "unfixable" (the patches will be downloaded and therefore can't be named differently). But the port lint post-commit hook sent me this error message only.
The "unfixable" warnings about the names of downloaded patchfiles are not supposed to be fixed -- the "port lint" warning is erroneous (as you know). It would be great if someone could fix this bug: http://trac.macosforge.org/projects/macports/ticket/13615 And while they're there, do this as well: http://trac.macosforge.org/projects/macports/ticket/13825
Ryan Schmidt wrote:
The "unfixable" warnings about the names of downloaded patchfiles are not supposed to be fixed -- the "port lint" warning is erroneous (as you know). It would be great if someone could fix this bug:
I committed a check if the file exists locally in files/: http://trac.macosforge.org/projects/macports/changeset/34082
And while they're there, do this as well:
I have no idea how to fix this. Before lint is run, the normal Portfile evaluation takes place which happens platform dependent. It wouldn't be a solution just to add all variants and platforms, because they might be conflicting which could influence linting IMHO. Rainer
On Feb 11, 2008, at 19:41, Rainer Müller wrote:
Ryan Schmidt wrote:
The "unfixable" warnings about the names of downloaded patchfiles are not supposed to be fixed -- the "port lint" warning is erroneous (as you know). It would be great if someone could fix this bug: http://trac.macosforge.org/projects/macports/ticket/13615
I committed a check if the file exists locally in files/: http://trac.macosforge.org/projects/macports/changeset/34082
And while they're there, do this as well: http://trac.macosforge.org/projects/macports/ticket/13825
I have no idea how to fix this. Before lint is run, the normal Portfile evaluation takes place which happens platform dependent. It wouldn't be a solution just to add all variants and platforms, because they might be conflicting which could influence linting IMHO.
Yeah, that's a trickier problem. Thanks for fixing 13615 though!
participants (3)
-
Rainer Müller
-
Ryan Schmidt
-
William Siegrist