Re: [30641] trunk/dports/www/squirrelmail/Portfile
Per a recent discussion on this list, php is not an invalid category, despite whatever lint says. On 1 Nov 2007, at 13:45, source_changes@macosforge.org wrote:
Revision 30641 Author markd@macports.org Date 2007-11-01 10:45:52 -0700 (Thu, 01 Nov 2007) Log MessageRemove invalid category.Modified Paths trunk/dports/www/squirrelmail/Portfile Diff Modified: trunk/dports/www/squirrelmail/Portfile (30640 => 30641)--- trunk/dports/www/squirrelmail/Portfile 2007-11-01 17:43:19 UTC (rev 30640) +++ trunk/dports/www/squirrelmail/Portfile 2007-11-01 17:45:52 UTC (rev 30641) @@ -4,7 +4,7 @@ name squirrelmail version 1.4.10a -categories www mail php +categories www mail maintainers nomaintainer description A webmail system which accesses mail over IMAP _______________________________________________ macports-changes mailing list macports-changes@lists.macosforge.org http://lists.macosforge.org/mailman/listinfo/macports-changes
Randall Wood rhwood@mac.com http://shyramblings.blogspot.com "The rules are simple: The ball is round. The game lasts 90 minutes. All the rest is just philosophy."
Right. So let's fix lint. What is the fix? My proposal was that lint should only check that the first listed category matches the directory the port is in. Is that acceptable? On Nov 1, 2007, at 14:56, Randall Wood wrote:
Per a recent discussion on this list, php is not an invalid category, despite whatever lint says.
On 1 Nov 2007, at 13:45, source_changes@macosforge.org wrote:
Revision: 30641 http://trac.macosforge.org/projects/macports/changeset/ 30641 Author: markd@macports.org Date: 2007-11-01 10:45:52 -0700 (Thu, 01 Nov 2007)
Log Message: ----------- Remove invalid category.
Modified Paths: -------------- trunk/dports/www/squirrelmail/Portfile
Modified: trunk/dports/www/squirrelmail/Portfile =================================================================== --- trunk/dports/www/squirrelmail/Portfile 2007-11-01 17:43:19 UTC (rev 30640) +++ trunk/dports/www/squirrelmail/Portfile 2007-11-01 17:45:52 UTC (rev 30641) @@ -4,7 +4,7 @@
name squirrelmail version 1.4.10a -categories www mail php +categories www mail maintainers nomaintainer
description A webmail system which accesses mail over IMAP
Ryan Schmidt <ryandesign@macports.org> writes:
Right. So let's fix lint. What is the fix? My proposal was that lint should only check that the first listed category matches the directory the port is in. Is that acceptable?
Amen. Lint should be updated. Also, I reverted the change so the php virtual category is restored on squirrelmail. Mark
Ryan Schmidt wrote:
On Nov 1, 2007, at 14:56, Randall Wood wrote:
Per a recent discussion on this list, php is not an invalid category, despite whatever lint says.
Right. So let's fix lint. What is the fix? My proposal was that lint should only check that the first listed category matches the directory the port is in. Is that acceptable?
Yes, the current category check in "lint" is broken. => It should only check the first/primary category. It's on my TODO, but if someone wants to fix it then by all means go straight ahead and do so... --anders
participants (4)
-
Anders F Björklund
-
markd＠macports.org
-
Randall Wood
-
Ryan Schmidt