UPDATE: take maintainership of sysutils/duplicity
Hi Just tried submitting a ticket for this but when I try to log onto Trac I get the following error: Login to trac failed! Message was "". Anyway heres a patch that adds me as the maintainer to sysutils/duplicity port, could someone with commit access take a look at this and commit it to SVN? Cheers Adam
On May 26, 2007, at 16:05, Adam Mercer wrote:
Just tried submitting a ticket for this but when I try to log onto Trac I get the following error:
Login to trac failed! Message was "".
Other users reported that a day or two ago and it's being investigated by the admins.
Anyway heres a patch that adds me as the maintainer to sysutils/duplicity port, could someone with commit access take a look at this and commit it to SVN?
It looks like you've done at least three things in that diff: 1. you've changed the maintainer 2. you've added checksums 3. you've reformatted the entire portfile 4. maybe something else; hard to tell because of 3. I don't like patches that do all these things at once. Especially whitespace/reformatting changes should be done by themselves, without any changes to the substance of the portfile, otherwise it's very difficult for others to later determine what substantial changes occurred in any given revision. I made you the maintainer and added the checksums in r25624: http://trac.macosforge.org/projects/macports/changeset/25624 If you want to submit another patch that just reformats the port or just makes other substantive changes, I can commit that too.
On 27/05/07, Ryan Schmidt <ryandesign@macports.org> wrote:
It looks like you've done at least three things in that diff:
1. you've changed the maintainer 2. you've added checksums 3. you've reformatted the entire portfile 4. maybe something else; hard to tell because of 3.
I don't like patches that do all these things at once. Especially whitespace/reformatting changes should be done by themselves, without any changes to the substance of the portfile, otherwise it's very difficult for others to later determine what substantial changes occurred in any given revision.
Thanks, I'll split up future patches.
I made you the maintainer and added the checksums in r25624:
http://trac.macosforge.org/projects/macports/changeset/25624
If you want to submit another patch that just reformats the port or just makes other substantive changes, I can commit that too.
Attached. Cheers Adam
I believe the Trac login issue has been resolved. Thanks everyone for your patience. - Kevin On May 27, 2007, at 12:13 AM, Ryan Schmidt wrote:
On May 26, 2007, at 16:05, Adam Mercer wrote:
Just tried submitting a ticket for this but when I try to log onto Trac I get the following error:
Login to trac failed! Message was "".
Other users reported that a day or two ago and it's being investigated by the admins.
Anyway heres a patch that adds me as the maintainer to sysutils/duplicity port, could someone with commit access take a look at this and commit it to SVN?
It looks like you've done at least three things in that diff:
1. you've changed the maintainer 2. you've added checksums 3. you've reformatted the entire portfile 4. maybe something else; hard to tell because of 3.
I don't like patches that do all these things at once. Especially whitespace/reformatting changes should be done by themselves, without any changes to the substance of the portfile, otherwise it's very difficult for others to later determine what substantial changes occurred in any given revision.
I made you the maintainer and added the checksums in r25624:
http://trac.macosforge.org/projects/macports/changeset/25624
If you want to submit another patch that just reformats the port or just makes other substantive changes, I can commit that too.
_______________________________________________ macports-dev mailing list macports-dev@lists.macosforge.org http://lists.macosforge.org/mailman/listinfo/macports-dev
On May 27, 2007, at 09:03, Adam Mercer wrote:
On 27/05/07, Ryan Schmidt wrote:
If you want to submit another patch that just reformats the port or just makes other substantive changes, I can commit that too.
Attached.
And committed! http://trac.macosforge.org/projects/macports/changeset/25862
participants (3)
-
Adam Mercer
-
Kevin Van Vechten
-
Ryan Schmidt