Re: [25656] trunk/dports/devel/pcre/Portfile
On May 27, 2007, at 11:37, source_changes@macosforge.org wrote:
Revision: 25656 http://trac.macosforge.org/projects/macports/changeset/25656 Author: nox@macports.org Date: 2007-05-27 09:37:40 -0700 (Sun, 27 May 2007)
Log Message: ----------- Added utf8 variant. Added standard documentation installation. Changed master sites order. Taken over.
Modified Paths: -------------- trunk/dports/devel/pcre/Portfile
Modified: trunk/dports/devel/pcre/Portfile =================================================================== --- trunk/dports/devel/pcre/Portfile 2007-05-27 16:29:56 UTC (rev 25655) +++ trunk/dports/devel/pcre/Portfile 2007-05-27 16:37:40 UTC (rev 25656) @@ -3,8 +3,9 @@ PortSystem 1.0 name pcre version 7.1 +revision 1 categories devel -maintainers nomaintainer@macports.org +maintainers nox description Perl Compatible Regular Expressions Library long_description \ The PCRE library is a set of functions that implement regular \ @@ -14,18 +15,20 @@
homepage http://www.pcre.org/ platforms darwin freebsd -master_sites sourceforge \ - ftp://ftp.fu-berlin.de/unix/misc/pcre/ \ - ftp://ftp.tin.org/pub/libs/pcre/ \ - ftp://ftp.csx.cam.ac.uk/pub/software/programming/ pcre/ - +master_sites ftp://ftp.fu-berlin.de/unix/misc/${name}/ \ + ftp://ftp.tin.org/pub/libs/${name}/ \ + ftp://ftp.csx.cam.ac.uk/pub/software/programming/$ {name}/ \ + sourceforge + use_bzip2 yes checksums md5 c678550aaf064a17bb4bb6ea36dd6d88 \ sha1 1bc54556368165e7ce5f59ac2a60aba7dec6365c \ rmd160 1df0f1e86435a7f77c694472bb23bc71433a60be
-configure.args --mandir=${prefix}/share/man \ - --enable-utf8 \ - --enable-unicode-properties +configure.args --docdir=${prefix}/share/doc/${name}-${version}
test.run yes + +variant utf8 description {Enable UTF-8 support} { + configure.args-append --enable-unicode-properties +}
So wait... users who had pcre 7.1_0 installed already had UTF-8 support. Now we upgrade to pcre 7.1_1 and we don't have UTF-8 support, unless we uninstall pcre and reinstall it with +utf8. Why was UTF-8 support made optional and non-default?
Le 27 mai 07 à 22:44, Ryan Schmidt a écrit :
On May 27, 2007, at 11:37, source_changes@macosforge.org wrote:
Revision: 25656 http://trac.macosforge.org/projects/macports/changeset/ 25656 Author: nox@macports.org Date: 2007-05-27 09:37:40 -0700 (Sun, 27 May 2007)
Log Message: ----------- Added utf8 variant. Added standard documentation installation. Changed master sites order. Taken over.
Modified Paths: -------------- trunk/dports/devel/pcre/Portfile
(...)
So wait... users who had pcre 7.1_0 installed already had UTF-8 support. Now we upgrade to pcre 7.1_1 and we don't have UTF-8 support, unless we uninstall pcre and reinstall it with +utf8. Why was UTF-8 support made optional and non-default?
First, I don't really like features being enabled by default. Second, as there is other ports with utf8 variant, i think this should be made a variant wherever it could be, for consistency's sake. -- Anthony Ramine, a lazy french student. nox@macports.org
On May 27, 2007, at 15:49, N_Ox wrote:
Le 27 mai 07 à 22:44, Ryan Schmidt a écrit :
On May 27, 2007, at 11:37, source_changes@macosforge.org wrote:
Revision: 25656 http://trac.macosforge.org/projects/macports/changeset/ 25656 Author: nox@macports.org Date: 2007-05-27 09:37:40 -0700 (Sun, 27 May 2007)
Log Message: ----------- Added utf8 variant. Added standard documentation installation. Changed master sites order. Taken over.
Modified Paths: -------------- trunk/dports/devel/pcre/Portfile
(...)
So wait... users who had pcre 7.1_0 installed already had UTF-8 support. Now we upgrade to pcre 7.1_1 and we don't have UTF-8 support, unless we uninstall pcre and reinstall it with +utf8. Why was UTF-8 support made optional and non-default?
First, I don't really like features being enabled by default. Second, as there is other ports with utf8 variant, i think this should be made a variant wherever it could be, for consistency's sake.
It's not about consistency really; it's about what most users will want. Features should be enabled by default if it's reasonable to expect people will want it, and UTF-8 support is reasonable to want in 2007. I cite: http://web.archive.org/web/20060222172940/darwinports.org/docs/ ch07s02.html Which says:
There are some guidelines for using variants:
* Never change the version of a port inside a variant. * Heavy usage of variants is considered bad style - keep the number of variants low. * Prefer function restricting variants over function enhancing ones. Make the default installation the one that serves most purposes.
participants (2)
-
N_Ox
-
Ryan Schmidt