Just a head-up for a new port submitted a while ago: http://trac.macports.org/projects/macports/ticket/11299 Gufo
On Feb 16, 2007, at 12:45 PM, Sbranzo wrote:
Just a head-up for a new port submitted a while ago: http://trac.macports.org/projects/macports/ticket/11299
Gufo
From my comment in the ticket: Committed in r22124, thanks for the contribution! Notes of interest: 1) "revision" defaults to zero, so no need to state it explicitly if that's the value used. 2) Number of files should be kept to a minimum, so a patch like that is unnecessary as users using the port are already using MacPorts, no need to instruct them to type port install to install the software. 3) No need to pass --prefix=${prefix} to the configure script, that's basically what MacPorts is for ;-) 4) Don't hardcode /opt/local in the Portfile, that's the default value of ${prefix} but users are free to choose another one; Portfile should be abstracted from explicit values as much as possible. Other than that, great work, keep those contributions coming! -jmpp PS: Ticket severity should not be Crash/Data loss ;-)
On 17/02/07 21:32, Juan Manuel Palacios wrote:
Committed in r22124, thanks for the contribution! Notes of interest:
2) Number of files should be kept to a minimum, so a patch like that is unnecessary as users using the port are already using MacPorts, no need to instruct them to type port install to install the software.
Ok fine, so it should be removed from the slrn port too, because it's taken from there.
4) Don't hardcode /opt/local in the Portfile, that's the default value of ${prefix} but users are free to choose another one; Portfile should be abstracted from explicit values as much as possible.
Ok.
PS: Ticket severity should not be Crash/Data loss ;-)
Ehm...*cough*cough* :-D Thanks, Gufo
On Feb 18, 2007, at 9:49 AM, Sbranzo wrote:
On 17/02/07 21:32, Juan Manuel Palacios wrote:
Committed in r22124, thanks for the contribution! Notes of interest:
2) Number of files should be kept to a minimum, so a patch like that is unnecessary as users using the port are already using MacPorts, no need to instruct them to type port install to install the software.
Ok fine, so it should be removed from the slrn port too, because it's taken from there.
Thanks for the note, I'm Cc'ing him right now to inform him of this. Olaf, I'm removing the patch-Makefile.in file from your slrn port as it has no added value, per the quoted discussion. Hope you don't feel I'm treading on your maintainer space ;-) Regards,... -jmpp
participants (2)
-
Juan Manuel Palacios
-
Sbranzo