Re: [27705] trunk/dports/x11/gtk2/Portfile
What would be the best way to check for darwin platforms with a version less than 8 in a Portfile? On 12 Aug 2007, at 09:50, source_changes@macosforge.org wrote:
Revision 27705 Author rhwood@macports.org Date 2007-08-12 06:50:02 -0700 (Sun, 12 Aug 2007) Log Message configure.env -> configure.*flags-append statements redo dependencies based on trace output replace ui_msg blah ; exit 1 statements with return 1 blah statements Modified Paths trunk/dports/x11/gtk2/Portfile Diff Modified: trunk/dports/x11/gtk2/Portfile (27704 => 27705) --- trunk/ dports/x11/gtk2/Portfile 2007-08-12 12:03:22 UTC (rev 27704) +++ trunk/dports/x11/gtk2/Portfile 2007-08-12 13:50:02 UTC (rev 27705) @@ -26,26 +26,44 @@ use_bzip2 yes -depends_lib port:glib2 port:tiff port:libpng port:atk port:pango \ - port:gettext lib:libX11.6:XFree86 +depends_build \ + port:perl5.8 \ + port:pkgconfig \ + port:gzip +depends_lib \ + port:cairo \ + port:fontconfig \ + port:freetype \ + port:glib2 \ + port:jpeg \ + port:tiff \ + port:libiconv \ + port:libpng \ + port:atk \ + port:pango \ + port:gettext \ + port:render \ + port:xrender \ + port:zlib \ + lib:libX11.6:xorg pre-configure { if {[variant_isset quartz]} { if { ![file exists ${prefix}/include/cairo/cairo- quartz.h] } { - ui_msg "\nYou must first build cairo with the quartz variant enabled. Please\nuninstall (or deactivate) the cairo port and reinstall by running:\n\n\"port install cairo +quartz\"\n" - exit 1 + return 1 "\nYou must first build cairo with the quartz variant enabled. Please\nuninstall (or deactivate) the cairo port and reinstall by running:\n\n\"port install cairo +quartz\"\n" } } if {[file exists ${prefix}/bin/cups-config]} { - ui_msg "\nThe cups-headers port may prevent building this port. Please uninstall\n (or deactivate) cups-headers and restart the build.\n" - exit 1 + return 1 "\nThe cups-headers port may prevent building this port. Please uninstall\n(or deactivate) cups-headers and restart the build.\n" } } +# older CFLAGS declaration - if the default optimization still causes problems +# we will revert to this +# CFLAGS="-O3 -funroll-loops -fstrict-aliasing" +configure.ldflags- append -lpango-1.0 +configure.cppflags-append -no-cpp-precomp - DX_LOCALE +configure.cflags-append -funroll-loops -fstrict-aliasing -configure.env LDFLAGS="-L${prefix}/lib -lpango-1.0" \ - CPPFLAGS="-I${prefix}/include -no-cpp-precomp -DX_LOCALE" \ - CFLAGS="-O3 -funroll-loops -fstrict-aliasing" - configure.args -- disable-shm --disable-gtk-doc --with-included-loaders \ --mandir=$ {prefix}/share/man _______________________________________________ macports-changes mailing list macports-changes@lists.macosforge.org http://lists.macosforge.org/mailman/listinfo/macports-changes
Randall Wood rhwood@mac.com http://shyramblings.blogspot.com "The rules are simple: The ball is round. The game lasts 90 minutes. All the rest is just philosophy."
Le 12 août 07 à 15:57, Randall Wood a écrit :
What would be the best way to check for darwin platforms with a version less than 8 in a Portfile?
On 12 Aug 2007, at 09:50, source_changes@macosforge.org wrote:
Revision 27705 Author rhwood@macports.org Date 2007-08-12 06:50:02 -0700 (Sun, 12 Aug 2007) Log Message configure.env -> configure.*flags-append statements redo dependencies based on trace output replace ui_msg blah ; exit 1 statements with return 1 blah statements Modified Paths trunk/dports/x11/gtk2/Portfile <snip>
On a side note, should not the return statement be `return -code 1 blah`? -- Anthony Ramine, a lazy french student. nox@macports.org
On 12 Aug 2007, at 10:23, N_Ox wrote:
Le 12 août 07 à 15:57, Randall Wood a écrit :
What would be the best way to check for darwin platforms with a version less than 8 in a Portfile?
On 12 Aug 2007, at 09:50, source_changes@macosforge.org wrote:
Revision 27705 Author rhwood@macports.org Date 2007-08-12 06:50:02 -0700 (Sun, 12 Aug 2007) Log Message configure.env -> configure.*flags-append statements redo dependencies based on trace output replace ui_msg blah ; exit 1 statements with return 1 blah statements Modified Paths trunk/dports/x11/gtk2/Portfile <snip>
On a side note, should not the return statement be `return -code 1 blah`?
Beats me. This statement is not documented in "man portfile" or in the guide at http://geeklair.net/new_macports_guide Randall Wood rhwood@mac.com http://shyramblings.blogspot.com "The rules are simple: The ball is round. The game lasts 90 minutes. All the rest is just philosophy."
Le 12 août 07 à 16:39, Randall Wood a écrit :
On 12 Aug 2007, at 10:23, N_Ox wrote:
Le 12 août 07 à 15:57, Randall Wood a écrit :
What would be the best way to check for darwin platforms with a version less than 8 in a Portfile?
On 12 Aug 2007, at 09:50, source_changes@macosforge.org wrote:
Revision 27705 Author rhwood@macports.org Date 2007-08-12 06:50:02 -0700 (Sun, 12 Aug 2007) Log Message configure.env -> configure.*flags-append statements redo dependencies based on trace output replace ui_msg blah ; exit 1 statements with return 1 blah statements Modified Paths trunk/dports/x11/gtk2/Portfile <snip>
On a side note, should not the return statement be `return -code 1 blah`?
Beats me. This statement is not documented in "man portfile" or in the guide at http://geeklair.net/new_macports_guide
This is a standard TCL procedure, see return(n). -- Anthony Ramine, a lazy french student. nox@macports.org
On Aug 12, 2007, at 10:40, N_Ox wrote:
Le 12 août 07 à 16:39, Randall Wood a écrit :
On 12 Aug 2007, at 10:23, N_Ox wrote:
Le 12 août 07 à 15:57, Randall Wood a écrit :
What would be the best way to check for darwin platforms with a version less than 8 in a Portfile?
On 12 Aug 2007, at 09:50, source_changes@macosforge.org wrote:
Revision 27705 Author rhwood@macports.org Date 2007-08-12 06:50:02 -0700 (Sun, 12 Aug 2007) Log Message configure.env -> configure.*flags-append statements redo dependencies based on trace output replace ui_msg blah ; exit 1 statements with return 1 blah statements Modified Paths trunk/dports/x11/gtk2/Portfile <snip>
On a side note, should not the return statement be `return -code 1 blah`?
Beats me. This statement is not documented in "man portfile" or in the guide at http://geeklair.net/new_macports_guide
This is a standard TCL procedure, see return(n).
I'm not familiar with standard TCL procedures, and I'd estimate most port authors aren't. We just know enough to get by to write portfiles. I for one would certainly appreciate it if everything necessary to write portfiles, including standard TCL, were documented in the guide and/or the manpage.
Le 14 août 07 à 02:54, Ryan Schmidt a écrit :
On Aug 12, 2007, at 10:40, N_Ox wrote:
Le 12 août 07 à 16:39, Randall Wood a écrit :
On 12 Aug 2007, at 10:23, N_Ox wrote:
Le 12 août 07 à 15:57, Randall Wood a écrit :
What would be the best way to check for darwin platforms with a version less than 8 in a Portfile?
On 12 Aug 2007, at 09:50, source_changes@macosforge.org wrote:
Revision 27705 Author rhwood@macports.org Date 2007-08-12 06:50:02 -0700 (Sun, 12 Aug 2007) Log Message configure.env -> configure.*flags-append statements redo dependencies based on trace output replace ui_msg blah ; exit 1 statements with return 1 blah statements Modified Paths trunk/dports/x11/gtk2/Portfile <snip>
On a side note, should not the return statement be `return -code 1 blah`?
Beats me. This statement is not documented in "man portfile" or in the guide at http://geeklair.net/new_macports_guide
This is a standard TCL procedure, see return(n).
I'm not familiar with standard TCL procedures, and I'd estimate most port authors aren't. We just know enough to get by to write portfiles. I for one would certainly appreciate it if everything necessary to write portfiles, including standard TCL, were documented in the guide and/or the manpage.
I agree with you and I would even say that it would be better to write an "error" alias to the "return" procedure, something like that: error blah Regards, -- Anthony Ramine, the infamous MacPorts Trac slave. nox@macports.org
N_Ox <n.oxyde@gmail.com> writes:
Beats me. This statement is not documented in "man portfile" or in the guide at http://geeklair.net/new_macports_guide
This is a standard TCL procedure, see return(n).
I'm not familiar with standard TCL procedures, and I'd estimate most port authors aren't. We just know enough to get by to write portfiles. I for one would certainly appreciate it if everything necessary to write portfiles, including standard TCL, were documented in the guide and/or the manpage.
Well there's a place all prepared for the Tcl primitives. The intent is to list them all. It just isn't the top priority right now, but it is getting close. And since a Portfile can contain any valid Tcl, is this the best link for Tcl reference? http://tmml.sourceforge.net/doc/tcl/ Mark
Le 14 août 07 à 04:17, markd@macports.org a écrit :
N_Ox <n.oxyde@gmail.com> writes:
Beats me. This statement is not documented in "man portfile" or in the guide at http://geeklair.net/new_macports_guide
This is a standard TCL procedure, see return(n).
I'm not familiar with standard TCL procedures, and I'd estimate most port authors aren't. We just know enough to get by to write portfiles. I for one would certainly appreciate it if everything necessary to write portfiles, including standard TCL, were documented in the guide and/or the manpage.
Well there's a place all prepared for the Tcl primitives. The intent is to list them all. It just isn't the top priority right now, but it is getting close. And since a Portfile can contain any valid Tcl, is this the best link for Tcl reference? http://tmml.sourceforge.net/doc/tcl/
Mark
A great thanks for your link, way nicer than the official tcl documentation. -- Anthony Ramine, the infamous MacPorts Trac slave. nox@macports.org
N_Ox <n.oxyde@gmail.com> writes:
And since a Portfile can contain any valid Tcl, is
this the best link for Tcl reference? http://tmml.sourceforge.net/doc/tcl/
Mark
A great thanks for your link, way nicer than the official tcl documentation.
You mean the Sourceforge Tcl link? Is that not the official docs? I just Googled it up. But now that you mention it, it does seem like it looks strangely coherent compared to what I recall finding when I started making ports. The only thing I found then seemed very, very ugly. Mark
Le 14 août 07 à 04:33, markd@macports.org a écrit :
N_Ox <n.oxyde@gmail.com> writes:
And since a Portfile can contain any valid Tcl, is
this the best link for Tcl reference? http://tmml.sourceforge.net/doc/ tcl/
Mark
A great thanks for your link, way nicer than the official tcl documentation.
You mean the Sourceforge Tcl link? Is that not the official docs? I just Googled it up. But now that you mention it, it does seem like it looks strangely coherent compared to what I recall finding when I started making ports. The only thing I found then seemed very, very ugly.
Mark
Well, http://www.tcl.tk/ is even uglier. -- Anthony Ramine, the infamous MacPorts Trac slave. nox@macports.org
N_Ox <n.oxyde@gmail.com> writes:
the best link for Tcl reference? http://tmml.sourceforge.net/doc/ tcl/
Mark
A great thanks for your link, way nicer than the official tcl documentation.
You mean the Sourceforge Tcl link? Is that not the official docs? I just Googled it up. But now that you mention it, it does seem like it looks strangely coherent compared to what I recall finding when I started making ports. The only thing I found then seemed very, very ugly.
Mark
Well, http://www.tcl.tk/ is even uglier.
Definitely. No, I like the appearance of the sourceforge docs too, at least at first glance. Mark
if everything necessary to write portfiles, including standard TCL, were
documented in the guide and/or the manpage.
Some questions: 1) So is the portfile manpage not exhaustive, and if not what is missing? Or do I have to mine the base code for an exhaustive list? 2) The manpage calls them "Tcl Extensions" -is that the best term or is "Tcl primitives" better? Mark
Le 14 août 07 à 06:56, markd@macports.org a écrit :
if everything necessary to write portfiles, including standard TCL, were
documented in the guide and/or the manpage.
Some questions:
1) So is the portfile manpage not exhaustive, and if not what is missing? Or do I have to mine the base code for an exhaustive list? 2) The manpage calls them "Tcl Extensions" -is that the best term or is "Tcl primitives" better?
Mark
Tcl Extensions are procedures added to TCL by MacPorts, so they are really extensions. -- Anthony Ramine, the infamous MacPorts Trac slave. nox@macports.org
participants (4)
-
markd@macports.org
-
N_Ox
-
Randall Wood
-
Ryan Schmidt