Fwd: [21973] trunk/dports/java/hibernate3/Portfile
Hey Kevin! Could I ask you to please take a look at this last commit of mine? You think your recent clean up in trunk/base/ might have something to do with these empty depends_lib lines causing indexing to fail? I can't think of anything else since you're practically the only one hacking on base at the moment (and a big woot for being so brave! ;-) Regards,.. -jmpp Begin forwarded message:
From: source_changes@macosforge.org Date: February 12, 2007 6:09:23 PM GMT-04:00 To: macports-changes@lists.macosforge.org Subject: [21973] trunk/dports/java/hibernate3/Portfile Reply-To: macports-dev@lists.macosforge.org
Revision 21973007-02-12 14:09:23 -0800 (Mon, 12 Feb 2007)
Log Message Cleaning another emtpy depends_lib line. This Portfile was last updated back in December and hadn't failed indexing until today, which clearly means something new in svn TOT is choking with these empty lines. Though I do like this stricter checking, I believe this matter should be looked into.
Modified Paths • trunk/dports/java/hibernate3/Portfile
Diff
Modified: trunk/dports/java/hibernate3/Portfile (21972 => 21973) --- trunk/dports/java/hibernate3/Portfile 2007-02-12 22:05:04 UTC (rev 21972) +++ trunk/dports/java/hibernate3/Portfile 2007-02-12 22:09:23 UTC (rev 21973) @@ -29,7 +29,6 @@ bin:ant:apache-ant \ bin:antlr:antlr \ port:junit -depends_lib
use_configure no
_______________________________________________ macports-changes mailing list macports-changes@lists.macosforge.org http://lists.macosforge.org/mailman/listinfo/macports-changes
Ok, I looked. I believe it has to do with a `set ${option} \$args` line that used to be part of an eval but is no longer. When it was double-evaluated if $args was empty it would evaluate to just `set $ {option}` which does a read, but in the current system it evaluates to the equivalent of `set ${option} {}`, which does a write with an empty value. This fails to validate, and so it raises an error. I believe this to be a good thing. I certainly believe we shouldn't code in a kludge to get the old double-eval behaviour back ;) I assume that with your fixes everything is indexing properly now, yes? So this shouldn't be a problem? -Kevin Ballard On Feb 12, 2007, at 5:14 PM, Juan Manuel Palacios wrote:
Hey Kevin! Could I ask you to please take a look at this last commit of mine? You think your recent clean up in trunk/base/ might have something to do with these empty depends_lib lines causing indexing to fail? I can't think of anything else since you're practically the only one hacking on base at the moment (and a big woot for being so brave! ;-)
-- Kevin Ballard http://kevin.sb.org eridius@macports.org http://www.tildesoft.com
On Feb 12, 2007, at 9:38 PM, Kevin Ballard wrote:
Ok, I looked. I believe it has to do with a `set ${option} \$args` line that used to be part of an eval but is no longer. When it was double-evaluated if $args was empty it would evaluate to just `set ${option}` which does a read, but in the current system it evaluates to the equivalent of `set ${option} {}`, which does a write with an empty value. This fails to validate, and so it raises an error.
I believe this to be a good thing. I certainly believe we shouldn't code in a kludge to get the old double-eval behaviour back ;)
I also believe it's a good thing, increasingly stricter checks on our Portfiles is something we all want, I'd think ;-) So all in all your clean ups delivered good results, these two Portfiles had empty depends_lib lines which were throwing "invalid depspec" errors. Key, no val lines shouldn't be there in the first place, so I removed them.
I assume that with your fixes everything is indexing properly now, yes? So this shouldn't be a problem?
I removed them from the portfiles so I'd guess the problem is gone, I indexed properly.... but then I realized I was doing it with 1.3.2, will give it a try with 1.4 later on today.
-Kevin Ballard
Thanks for taking the time to give some love to our lonely base code, woot! -jmpp
On Feb 12, 2007, at 5:14 PM, Juan Manuel Palacios wrote:
Hey Kevin! Could I ask you to please take a look at this last commit of mine? You think your recent clean up in trunk/base/ might have something to do with these empty depends_lib lines causing indexing to fail? I can't think of anything else since you're practically the only one hacking on base at the moment (and a big woot for being so brave! ;-)
-- Kevin Ballard http://kevin.sb.org eridius@macports.org http://www.tildesoft.com
participants (2)
-
Juan Manuel Palacios
-
Kevin Ballard