-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Hi, I'm having some problems with liveupdate. The first was to find some documentation about it. I only found it in "man portfile" and it wasn't very precise (for example regarding the regex syntax). The second is even regex of some Portfiles in the repository are not working. For example the zlib port (and others). It uses this regex: "<B> *${name} (\\d+(?:\\.\\d+)*)</B>" But it isn't working and I don't know why; it should match the text on the webpage. After I changed it to the following it worked: "<B> *${name} (\[0-9\]+(?:\\.\[0-9\]+)*)</B>" Is \d and such special characters allowed or not? I'm not sure about it. Thanks for your help, Simon PS: I attached a patch for zlib to fix this problem. Also added another patch to fix some whitespace and other minor issues in the zlib Portfile. CCing one of the maintainers. - -- + privacy is necessary + using http://gnupg.org + public key id: 0x6115F804EFB33229 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (Darwin) iD8DBQFGlPpAYRX4BO+zMikRCiLhAJ9yKH4J3z29zoWoe8vJdKC/erqo0gCeKq+k 1BGeZFTfWwUaikQY+q+fmFI= =bVyA -----END PGP SIGNATURE----- --- /opt/local/var/macports/sources/rsync.macports.org/release/ports/archivers/zlib/Portfile 2007-07-11 17:33:56.000000000 +0200 +++ /Users/simonruderich/Portfile 2007-07-11 17:34:04.000000000 +0200 @@ -53,5 +53,4 @@ } livecheck.check regex -livecheck.url ${homepage} -livecheck.regex "<B> *${name} (\\d+(?:\\.\\d+)*)</B>" +livecheck.regex "<B> *${name} (\[0-9\]+(?:\\.\[0-9\]+)*)</B>" 4,25d3 < name zlib < version 1.2.3 < revision 1 < categories archivers < maintainers landonf@macports.org ryandesign \ < openmaintainer@macports.org < description zlib lossless data-compression library < long_description \ < zlib is designed to be a free, general-purpose, \ < legally unencumbered, lossless data-compression \ < library for use on virtually any computer hardware \ < and operating system. < homepage http://www.zlib.net/ < platforms darwin freebsd < < master_sites ${homepage} http://www.gzip.org/zlib/ \ < sourceforge:libpng < < use_bzip2 yes < checksums md5 dee233bf288ee795ac96a98cc2e369b6 \ < sha1 967e280f284d02284b0cd8872a8e2e04bfdc7283 \ < rmd160 cfba9984b354dcc38da49331457e6bfc861c6f51 27c5,26 < patchfiles patch-Makefile-static ---
name zlib version 1.2.3 revision 1 categories archivers maintainers landonf@macports.org ryandesign \ openmaintainer@macports.org description zlib lossless data-compression library long_description zlib is designed to be a free, general-purpose, \ legally unencumbered, lossless data-compression \ library for use on virtually any computer hardware \ and operating system. homepage http://www.zlib.net/ platforms darwin freebsd master_sites ${homepage} http://www.gzip.org/zlib/ \ sourceforge:libpng
use_bzip2 yes checksums md5 dee233bf288ee795ac96a98cc2e369b6 \ sha1 967e280f284d02284b0cd8872a8e2e04bfdc7283 \ rmd160 cfba9984b354dcc38da49331457e6bfc861c6f51
patchfiles patch-Makefile-static 29c28 < patchfiles-append patch-Makefile-universal
patchfiles-append patch-Makefile-universal 32,33c31 < configure.args --shared < configure.universal_args
configure.args --shared 35c33 < test.run yes
test.run yes 37c35 < set docdir ${prefix}/share/doc/${name}-${version}
set docdir ${prefix}/share/doc/${name}-${version} 39c37 < destroot.destdir prefix=${destroot}${prefix}
destroot.destdir prefix=${destroot}${prefix} 42,43c40,41 < xinstall -m 0755 -d ${destroot}${docdir} < xinstall -m 0644 -W ${worksrcpath} ChangeLog FAQ README ${destroot}${docdir}
xinstall -m 0755 -d ${destroot}${docdir} xinstall -m 0644 -W ${worksrcpath} ChangeLog FAQ README ${destroot}${docdir} 47,52c45,50 < post-destroot { < set examplesdir ${docdir}/examples < < xinstall -m 0755 -d ${destroot}${examplesdir} < eval xinstall -m 0644 [glob ${worksrcpath}/example{.c,s/*}] ${destroot}${examplesdir} < }
post-destroot { set examplesdir ${docdir}/examples
xinstall -m 0755 -d ${destroot}${examplesdir} eval xinstall -m 0644 [glob ${worksrcpath}/example{.c,s/*}] ${destroot}${examplesdir} }
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Now I checked it with other installed ports. It seems there are some problems with livecheck. "port livecheck installed" returns this: apr seems to have been updated (port version: 1.2.9, new version: 1.2.8) Error: cannot check if apr-util was updated (regex didn't match) clearsilver seems to have been updated (port version: 0.10.4, new version: 0.10.2) Error: cannot check if db44 was updated (regex didn't match) Error: cannot check if gettext was updated (regex didn't match) Error: cannot check if libxml2 was updated (regex didn't match) Error: cannot check if libxslt was updated (regex didn't match) Error: cannot check if nano was updated (regex didn't match) Error: cannot check if ncurses was updated (regex didn't match) Error: cannot check if ncursesw was updated (regex didn't match) pcre seems to have been updated (port version: 7.1, new version: 7.2) Error: cannot check if perl5.8 was updated (regex didn't match) Error: cannot check if popt was updated (regex didn't match) Error: cannot check if readline was updated (regex didn't match) Simon - -- + privacy is necessary + using http://gnupg.org + public key id: 0x6115F804EFB33229 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (Darwin) iD8DBQFGlQlzYRX4BO+zMikRCkmMAJ4jC22XeSNTXhDY1LS7DytMEUlTJQCgo/us kR5m1i8BoUKsCpEPMTZllO0= =v/4o -----END PGP SIGNATURE-----
Citando Simon Ruderich :
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512
Now I checked it with other installed ports. It seems there are some problems with livecheck.
No, those are not "problems". It is a feature (called defaulting to something that makes sense in general but may fail).
"port livecheck installed" returns this:
apr seems to have been updated (port version: 1.2.9, new version: 1.2.8) Error: cannot check if apr-util was updated (regex didn't match) clearsilver seems to have been updated (port version: 0.10.4, new version: 0.10.2) Error: cannot check if db44 was updated (regex didn't match) Error: cannot check if gettext was updated (regex didn't match) Error: cannot check if libxml2 was updated (regex didn't match) Error: cannot check if libxslt was updated (regex didn't match) Error: cannot check if nano was updated (regex didn't match) Error: cannot check if ncurses was updated (regex didn't match) Error: cannot check if ncursesw was updated (regex didn't match) pcre seems to have been updated (port version: 7.1, new version: 7.2) Error: cannot check if perl5.8 was updated (regex didn't match) Error: cannot check if popt was updated (regex didn't match) Error: cannot check if readline was updated (regex didn't match)
1) Error: cannot check if apr-util was updated (regex didn't match) is the message you get for ports that have not any livecheck configuration and for which the default does not work (the default being fetching on freshmeat I believe) either because the project is not declared on the default site either it has another name. 2) pcre seems to have been updated (port version: 7.1, new version: 7.2) That's a good message indicating that pcre may need to be updated... 3) apr seems to have been updated (port version: 1.2.9, new version: 1.2.8) This happens if freshmeat has a project declared for this name but the page is not as up-to-date as the port. The problem is upstream (developper) does not change the project info on freshmeat at every release, blame them. Or the port maintainer may try to configure livecheck for it to fetch version on an up-to-date site. But since this feature is mostly useful for the port-maintainer, he may not need this to know when a port needs upgrading. Emmanuel
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Emmanuel Hainry wrote:
Citando Simon Ruderich :
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512
Now I checked it with other installed ports. It seems there are some problems with livecheck.
No, those are not "problems". It is a feature (called defaulting to something that makes sense in general but may fail).
Oh, sorry. Then I have overreacted a bit. But I couldn't find any information on how this works. Thanks for your answer.
"port livecheck installed" returns this:
apr seems to have been updated (port version: 1.2.9, new version: 1.2.8) Error: cannot check if apr-util was updated (regex didn't match) clearsilver seems to have been updated (port version: 0.10.4, new version: 0.10.2) Error: cannot check if db44 was updated (regex didn't match) Error: cannot check if gettext was updated (regex didn't match) Error: cannot check if libxml2 was updated (regex didn't match) Error: cannot check if libxslt was updated (regex didn't match) Error: cannot check if nano was updated (regex didn't match) Error: cannot check if ncurses was updated (regex didn't match) Error: cannot check if ncursesw was updated (regex didn't match) pcre seems to have been updated (port version: 7.1, new version: 7.2) Error: cannot check if perl5.8 was updated (regex didn't match) Error: cannot check if popt was updated (regex didn't match) Error: cannot check if readline was updated (regex didn't match)
1) Error: cannot check if apr-util was updated (regex didn't match)
is the message you get for ports that have not any livecheck configuration and for which the default does not work (the default being fetching on freshmeat I believe) either because the project is not declared on the default site either it has another name.
Oh ok, then the Portfile should be fixed. This would remove this problem.
2) pcre seems to have been updated (port version: 7.1, new version: 7.2)
That's a good message indicating that pcre may need to be updated...
3) apr seems to have been updated (port version: 1.2.9, new version: 1.2.8)
This happens if freshmeat has a project declared for this name but the page is not as up-to-date as the port. The problem is upstream (developper) does not change the project info on freshmeat at every release, blame them. Or the port maintainer may try to configure livecheck for it to fetch version on an up-to-date site. But since this feature is mostly useful for the port-maintainer, he may not need this to know when a port needs upgrading.
Ok, thanks for the info. Maybe "port livecheck" should check if the release number of the homepage is greater then the one in the Portfile and only then print a "needs update" message. What do you think?
Emmanuel
Thanks for your answers, but I have still two questions. "The aim of livecheck is to give the maintainers a quick information if the Portfile needs an update." Is this statement correct? What is with the other "regex didn't match" messages for Portfiles which have a correct specification of the liveupdate. Is this a limitation of the regex or am I missing something (again). Thanks for your help, Simon - -- + privacy is necessary + using http://gnupg.org + public key id: 0x6115F804EFB33229 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (Darwin) iD8DBQFGlS1dYRX4BO+zMikRCtd2AJ44QymM5hcaqojCy1UwbdVL8z+P/QCcCUtQ Ks/+o0/OGb0RxtAO+ZtE2B8= =GkA/ -----END PGP SIGNATURE-----
On Jul 11, 2007, at 10:41, Simon Ruderich wrote:
I'm having some problems with liveupdate.
The first was to find some documentation about it. I only found it in "man portfile" and it wasn't very precise (for example regarding the regex syntax).
That's the only place I know of where it's documented. I expect that the regex syntax is standard PCRE syntax, but things like slashes and other special symbols need to be escaped from the TCL interpreter.
The second is even regex of some Portfiles in the repository are not working. For example the zlib port (and others). It uses this regex:
"<B> *${name} (\\d+(?:\\.\\d+)*)</B>"
But it isn't working and I don't know why; it should match the text on the webpage. After I changed it to the following it worked:
"<B> *${name} (\[0-9\]+(?:\\.\[0-9\]+)*)</B>"
Is \d and such special characters allowed or not? I'm not sure about it.
I'm sorry, I didn't see your message and already fixed the zlib liveupdate. I changed it to this: livecheck.regex "${name}-(\\\\d+(?:\\\\.\\\\d+)*)\\\\.tar\\\\.bz2" I'm having a hard time figuring out, however, why I need *4* slashes every time PCRE syntax would lead me to expect to need only one. One doubled slash will be to escape it from the TCL string, but why it needs to be doubled again, I'm not sure. I have a sneaking suspicion that something in the livecheck processor changed between MacPorts 1.4.42 and 1.5.0 to cause this, because I had to fix the livecheck of several of my ports recently.
PS: I attached a patch for zlib to fix this problem. Also added another patch to fix some whitespace and other minor issues in the zlib Portfile. CCing one of the maintainers.
Landon is the true maintainer of zlib. I only jumped in because I thought Landon had abandoned the port, but it turned out he hadn't. I say it's bad form to do both whitespace changes and other changes in one commit. Makes it difficult to see later what functional changes were made, when a straightforward diff shows every line to have changed because of whitespace adjustments. Ideally, each change should be committed separately. Also, whitespace is currently something of a personal preference of the maintainer. In fact, Landon has specifically complained before when the whitespace of the zlib port was changed without his consent. See: http://trac.macosforge.org/projects/macports/changeset/23414 We should leave a port's whitespace up to its maintainer. And, your diffs are difficult to read because they are in context format (well, the "whitespace and other minor issues" one is), and because they're pasted into the email, which has probably reformatted them some. Please submit unified diffs instead, ideally attached to a ticket in Trac, or if it must be by email, then as an attachment, not inline.
On Jul 11, 2007, at 14:19, Simon Ruderich wrote:
"port livecheck installed" returns this:
apr seems to have been updated (port version: 1.2.9, new version: 1.2.8) Error: cannot check if apr-util was updated (regex didn't match) clearsilver seems to have been updated (port version: 0.10.4, new version: 0.10.2) Error: cannot check if db44 was updated (regex didn't match) Error: cannot check if gettext was updated (regex didn't match) Error: cannot check if libxml2 was updated (regex didn't match) Error: cannot check if libxslt was updated (regex didn't match) Error: cannot check if nano was updated (regex didn't match) Error: cannot check if ncurses was updated (regex didn't match) Error: cannot check if ncursesw was updated (regex didn't match) pcre seems to have been updated (port version: 7.1, new version: 7.2) Error: cannot check if perl5.8 was updated (regex didn't match) Error: cannot check if popt was updated (regex didn't match) Error: cannot check if readline was updated (regex didn't match)
1) Error: cannot check if apr-util was updated (regex didn't match)
is the message you get for ports that have not any livecheck configuration and for which the default does not work (the default being fetching on freshmeat I believe) either because the project is not declared on the default site either it has another name.
Oh ok, then the Portfile should be fixed. This would remove this problem.
2) pcre seems to have been updated (port version: 7.1, new version: 7.2)
That's a good message indicating that pcre may need to be updated...
3) apr seems to have been updated (port version: 1.2.9, new version: 1.2.8)
This happens if freshmeat has a project declared for this name but the page is not as up-to-date as the port. The problem is upstream (developper) does not change the project info on freshmeat at every release, blame them. Or the port maintainer may try to configure livecheck for it to fetch version on an up-to-date site. But since this feature is mostly useful for the port-maintainer, he may not need this to know when a port needs upgrading.
Ok, thanks for the info. Maybe "port livecheck" should check if the release number of the homepage is greater then the one in the Portfile and only then print a "needs update" message. What do you think?
If you read up on livecheck, you will see that it has many different modes of operation -- many places from which it can attempt to get a program's most recent version info -- be that sourceforge, freshmeat, the project's homepage, etc. Indeed, what you describe is one possible way livecheck can work -- provided the port author configures *how* to extract the current version number from that project's homepage, since everybody writes their web pages in a different way.
Emmanuel
Thanks for your answers, but I have still two questions.
"The aim of livecheck is to give the maintainers a quick information if the Portfile needs an update." Is this statement correct?
Yes, that's correct. livecheck is a feature meant to help port maintainers. Anybody else -- port users, for example -- may also use it, of course, but some maintainers may not have set up livecheck information for their ports, as you've seen. Maybe they're subscribed to a project's announce list, for example, so they learn about new versions of the project that way. In this way, you may run into ports where livecheck doesn't work and the maintainer doesn't care. They may accept patches, though, if you would like to figure out how to enable livecheck for that port and contribute it to the maintainer.
What is with the other "regex didn't match" messages for Portfiles which have a correct specification of the liveupdate. Is this a limitation of the regex or am I missing something (again).
It could mean that the project's homepage is offline. Or it could mean the livecheck specification was not in fact correct in the portfile, either because the port author made a mistake, or because MacPorts changed the way the livecheck information is interpreted, or because the project's homepage has changed in some way and a new livecheck needs to be written.
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Hi, thanks for your reply. First I want to say sorry for my late answer but I have been busy with school stuff in the last few weeks. Ryan Schmidt wrote:
If you read up on livecheck, you will see that it has many different modes of operation -- many places from which it can attempt to get a program's most recent version info -- be that sourceforge, freshmeat, the project's homepage, etc. Indeed, what you describe is one possible way livecheck can work -- provided the port author configures *how* to extract the current version number from that project's homepage, since everybody writes their web pages in a different way.
Then livecheck is a really very useful feature. Thanks for your quick introduction in its possibilities.
What is with the other "regex didn't match" messages for Portfiles which have a correct specification of the liveupdate. Is this a limitation of the regex or am I missing something (again).
It could mean that the project's homepage is offline. Or it could mean the livecheck specification was not in fact correct in the portfile, either because the port author made a mistake, or because MacPorts changed the way the livecheck information is interpreted, or because the project's homepage has changed in some way and a new livecheck needs to be written.
I think it would be better if the message could be a bit more precise; like "homepage not available". It would also be nice if port could print (only in debug mode of course) the regex it used to check the page. This would help with the multiple escape issue. So the maintainer knows what's going wrong. Ryan Schmidt wrote:
On Jul 11, 2007, at 10:41, Simon Ruderich wrote:
I'm having some problems with liveupdate.
The first was to find some documentation about it. I only found it in "man portfile" and it wasn't very precise (for example regarding the regex syntax).
That's the only place I know of where it's documented. I expect that the regex syntax is standard PCRE syntax, but things like slashes and other special symbols need to be escaped from the TCL interpreter.
Then I hope documentation for this is added to the new macports guide. This would make it much easier for users and developers to find this nice feature.
I'm sorry, I didn't see your message and already fixed the zlib liveupdate. I changed it to this:
livecheck.regex "${name}-(\\\\d+(?:\\\\.\\\\d+)*)\\\\.tar\\\\.bz2"
Thanks for your quick fix.
I'm having a hard time figuring out, however, why I need *4* slashes every time PCRE syntax would lead me to expect to need only one. One doubled slash will be to escape it from the TCL string, but why it needs to be doubled again, I'm not sure.
I have a sneaking suspicion that something in the livecheck processor changed between MacPorts 1.4.42 and 1.5.0 to cause this, because I had to fix the livecheck of several of my ports recently.
If I read the svn changelogs correctly then this was fixed in the current trunk. But I'm not entirely sure.
Landon is the true maintainer of zlib. I only jumped in because I thought Landon had abandoned the port, but it turned out he hadn't.
I say it's bad form to do both whitespace changes and other changes in one commit. Makes it difficult to see later what functional changes were made, when a straightforward diff shows every line to have changed because of whitespace adjustments. Ideally, each change should be committed separately.
Ok, thanks for your advice. Will do this in future.
Also, whitespace is currently something of a personal preference of the maintainer. In fact, Landon has specifically complained before when the whitespace of the zlib port was changed without his consent. See:
http://trac.macosforge.org/projects/macports/changeset/23414
We should leave a port's whitespace up to its maintainer.
Ok, will do this too ;-)
And, your diffs are difficult to read because they are in context format (well, the "whitespace and other minor issues" one is), and because they're pasted into the email, which has probably reformatted them some. Please submit unified diffs instead, ideally attached to a ticket in Trac, or if it must be by email, then as an attachment, not inline.
Sorry for this inconvenience. Normally I use unified diffs, just missed it for this patch. I don't know why the patch showed up as pasted into the email, because I'm sure I attached it. Hope this works better in the future. I don't like the trac system of macports so much because I noticed there are many fixes, patches and new portfiles in there and nobody checks them into the svn repository. But if something is mailed to the mailing list (or to the port maintainer) it's done very quickly. So I think the mailing list is a better and at the moment faster place for such patches. Thanks for your help and sorry again for my late reply, Simon - -- + privacy is necessary + using http://gnupg.org + public key id: 0x6115F804EFB33229 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (Darwin) iD8DBQFGr2g+YRX4BO+zMikRCuUVAJ9wmFl7b3pF3N7JfrGjdlMFRAYWDQCgwZfq O2A/lg+cb24rNLOnmetw+mY= =rpi1 -----END PGP SIGNATURE-----
On Jul 31, 2007, at 11:50, Simon Ruderich wrote:
What is with the other "regex didn't match" messages for Portfiles which have a correct specification of the liveupdate. Is this a limitation of the regex or am I missing something (again).
It could mean that the project's homepage is offline. Or it could mean the livecheck specification was not in fact correct in the portfile, either because the port author made a mistake, or because MacPorts changed the way the livecheck information is interpreted, or because the project's homepage has changed in some way and a new livecheck needs to be written.
I think it would be better if the message could be a bit more precise; like "homepage not available". It would also be nice if port could print (only in debug mode of course) the regex it used to check the page. This would help with the multiple escape issue. So the maintainer knows what's going wrong.
Reading portlivecheck.tcl, I see that if the homepage is not available, it already prints "cannot check if $portname was updated ($error)". It already prints the regex if the regex does not match. I suggested 2 weeks ago that the regex should always be printed, and since there have been no objections since then, I implemented that now (r27379). This is all in debug mode only.
I'm having a hard time figuring out, however, why I need *4* slashes every time PCRE syntax would lead me to expect to need only one. One doubled slash will be to escape it from the TCL string, but why it needs to be doubled again, I'm not sure.
I have a sneaking suspicion that something in the livecheck processor changed between MacPorts 1.4.42 and 1.5.0 to cause this, because I had to fix the livecheck of several of my ports recently.
If I read the svn changelogs correctly then this was fixed in the current trunk. But I'm not entirely sure.
Yes, I found the revision that broke it (r26041), Kevin Ballard provided a fix, and I tested and committed it (r27079).
I don't like the trac system of macports so much because I noticed there are many fixes, patches and new portfiles in there and nobody checks them into the svn repository. But if something is mailed to the mailing list (or to the port maintainer) it's done very quickly. So I think the mailing list is a better and at the moment faster place for such patches.
Trac is our bug tracking system, and the mailing list is our discussion system, so it seems to me that bugs are properly reported to Trac. However, the reporter must remember to Cc the appropriate people, otherwise nobody is notified of the ticket's existence. Also we don't have a good system in place for ports that are unmaintained. If you find forgotten patches in Trac, and the ticket is not assigned to someone and the port has no maintainer, email the list with the ticket URL and someone can have a look at them and commit them. If the ticket is assigned to someone, email that person. If the port has a maintainer, email that person.
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Ryan Schmidt wrote:
Reading portlivecheck.tcl, I see that if the homepage is not available, it already prints "cannot check if $portname was updated ($error)".
It already prints the regex if the regex does not match. I suggested 2 weeks ago that the regex should always be printed, and since there have been no objections since then, I implemented that now (r27379).
This is all in debug mode only.
Thanks for this fix, I hope it makes it into the next release.
Yes, I found the revision that broke it (r26041), Kevin Ballard provided a fix, and I tested and committed it (r27079).
Also thanks for this fix, but we should remember it means all the portfiles will need to be updated after this fix when the next version of macports is released.
Trac is our bug tracking system, and the mailing list is our discussion system, so it seems to me that bugs are properly reported to Trac. However, the reporter must remember to Cc the appropriate people, otherwise nobody is notified of the ticket's existence. Also we don't have a good system in place for ports that are unmaintained.
I'm not sure if this is mentioned in the documentation but it should also be displayed on the "New ticket" page. So it's clear for the reporter of the ticket to add this.
If you find forgotten patches in Trac, and the ticket is not assigned to someone and the port has no maintainer, email the list with the ticket URL and someone can have a look at them and commit them. If the ticket is assigned to someone, email that person. If the port has a maintainer, email that person.
I just did some search in Trac and send the links for the tickes to macports-dev. I also CCed the maintainers if the ports had one. Thanks for your help, Simon - -- + privacy is necessary + using http://gnupg.org + public key id: 0x6115F804EFB33229 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (Darwin) iD8DBQFGsa/WYRX4BO+zMikRCuLUAKDBD0119lpB0YowG9abAvPWIMRQBwCgjq6m fqu/NR9p8dVrwy/aqOaBfY0= =yK6y -----END PGP SIGNATURE-----
Sn Aug 2, 2007, at 05:20, Simon Ruderich wrote:
Ryan Schmidt wrote:
Reading portlivecheck.tcl, I see that if the homepage is not available, it already prints "cannot check if $portname was updated ($error)".
It already prints the regex if the regex does not match. I suggested 2 weeks ago that the regex should always be printed, and since there have been no objections since then, I implemented that now (r27379).
This is all in debug mode only.
Thanks for this fix, I hope it makes it into the next release.
So do I.
Yes, I found the revision that broke it (r26041), Kevin Ballard provided a fix, and I tested and committed it (r27079).
Also thanks for this fix, but we should remember it means all the portfiles will need to be updated after this fix when the next version of macports is released.
Only portfiles whose livecheck regexen have been updated to work with the "broken" livecheck code will again have to be updated to work with the "fixed" code. Portfiles which were never initially modified will work as usual again once 1.5.1 is released.
Trac is our bug tracking system, and the mailing list is our discussion system, so it seems to me that bugs are properly reported to Trac. However, the reporter must remember to Cc the appropriate people, otherwise nobody is notified of the ticket's existence. Also we don't have a good system in place for ports that are unmaintained.
I'm not sure if this is mentioned in the documentation but it should also be displayed on the "New ticket" page. So it's clear for the reporter of the ticket to add this.
It is quite clearly mentioned in the TracTicketing wiki page.
If you find forgotten patches in Trac, and the ticket is not assigned to someone and the port has no maintainer, email the list with the ticket URL and someone can have a look at them and commit them. If the ticket is assigned to someone, email that person. If the port has a maintainer, email that person.
I just did some search in Trac and send the links for the tickes to macports-dev. I also CCed the maintainers if the ports had one.
Thanks, I'll have a look at those.
participants (3)
-
Emmanuel Hainry
-
Ryan Schmidt
-
Simon Ruderich