Le 07-04-17 à 06:48, Ryan Schmidt a écrit :

I have fixed several issues with several portfiles. There was an agreement on the list some months ago that things should be this way, so these commits simply bring noncompliant portfiles back into compliance with the following:

- svn:keywords should be set to Id (capital I, lowercase d)

http://trac.macosforge.org/projects/macports/changeset/24131 http://trac.macosforge.org/projects/macports/changeset/24132 http://trac.macosforge.org/projects/macports/changeset/24133 http://trac.macosforge.org/projects/macports/changeset/24134 http://trac.macosforge.org/projects/macports/changeset/24135 http://trac.macosforge.org/projects/macports/changeset/24136 http://trac.macosforge.org/projects/macports/changeset/24137 http://trac.macosforge.org/projects/macports/changeset/24138

- svn:eol-style should be set to native

http://trac.macosforge.org/projects/macports/changeset/24140

- svn:executable should not be set

http://trac.macosforge.org/projects/macports/changeset/24139

- Portfiles should begin with the line "# $Id$" and then a blank line

http://trac.macosforge.org/projects/macports/changeset/24131 http://trac.macosforge.org/projects/macports/changeset/24141 http://trac.macosforge.org/projects/macports/changeset/24142 http://trac.macosforge.org/projects/macports/changeset/24143

To ensure that the correct properties automatically get set on your new Portfiles, you can edit your ~/.subversion/config file, turn auto-props on, and add this auto-prop definition:

Portfile = svn:eol-style=native;svn:keywords=Id

For consistency and conformance with the Subversion documentation let's please use Id, not id, for the keyword name.

This recommendation should probably be in the documentation somewhere but I haven't looked yet where it might best be included. If someone else would add this to the wiki, or even just point out where in the wiki it should go, that would be appreciated.

http://trac.macosforge.org/projects/macports/wiki/NewCommittersGuide yves

On Apr 17, 2007, at 16:19, Landon Fuller wrote:

...

I once said I would work on a pre-commit hook script we could install which would reject any commit that did not conform with these requirements. I haven't gotten around to that yet, but I haven't forgotten either.

If we're going to be nazis, can the pre-commit hook just set this stuff magically? Or can we stop being nazis about it?

The pre-commit hook can only verify the transaction and either accept or reject it; it cannot modify the transaction. I think these are useful conventions to enforce, so I will work on a pre-commit hook to enforce this.

On Apr 17, 2007, at 2:57 PM, Landon Fuller wrote:

On Apr 17, 2007, at 14:33, Ryan Schmidt wrote:

...

On Apr 17, 2007, at 16:19, Landon Fuller wrote:

...

...

I once said I would work on a pre-commit hook script we could install which would reject any commit that did not conform with these requirements. I haven't gotten around to that yet, but I haven't forgotten either.

If we're going to be nazis, can the pre-commit hook just set this stuff magically? Or can we stop being nazis about it?

The pre-commit hook can only verify the transaction and either accept or reject it; it cannot modify the transaction.

I think these are useful conventions to enforce, so I will work on a pre-commit hook to enforce this.

I'm apathetically opposed -- I don't care about $Id$ tags in my Portfiles, or native line breaks. If there was a way to do this automatically I'd be all in favor, but enforcement rubs me the wrong way.

I agree in general with Landon. But I do agree with Ryan that our committers should set the following in their subversion config:

To ensure that the correct properties automatically get set on your new Portfiles, you can edit your ~/.subversion/config file, turn auto-props on, and add this auto-prop definition:

Portfile = svn:eol-style=native;svn:keywords=Id

James