Re: [27673] trunk/dports/editors/abiword/Portfile
On Aug 11, 2007, at 9:33 PM, source_changes@macosforge.org wrote:
Revision 27673 Author nox@macports.org Date 2007-08-11 18:33:19 -0700 (Sat, 11 Aug 2007) Log Message
abiword: * Removed superfluous configure.env variables. * Added check to be sure that either use_binary or use_source is enabled. Modified Paths
trunk/dports/editors/abiword/Portfile
configure.env \ - CPPFLAGS="-L${prefix}/lib -I${prefix}/include" \ - LDFLAGS="-L${prefix}/lib" \ CFLAGS="-no-cpp-precomp"
Shouldn't this remaining old style CFLAG declaration be taken care of too? "configure.cflags-append no-cpp-precomp", 'cause otherwise (as it is now) you're overriding the default CFLAGS we provide out of the box. Or is that intentional? (we have seen cases of default CFLAGS braking some builds due to, for instance, optimization). Regards,... -jmpp
Le 12 août 07 à 17:15, Juan Manuel Palacios a écrit :
On Aug 11, 2007, at 9:33 PM, source_changes@macosforge.org wrote:
Revision 27673 Author nox@macports.org Date 2007-08-11 18:33:19 -0700 (Sat, 11 Aug 2007) Log Messageabiword: * Removed superfluous configure.env variables. * Added check to be sure that either use_binary or use_source is enabled.Modified Paths trunk/dports/editors/abiword/Portfile
configure.env \ - CPPFLAGS="-L${prefix}/lib -I${prefix}/include" \ - LDFLAGS="-L${prefix}/lib" \ CFLAGS="-no-cpp-precomp"
Shouldn't this remaining old style CFLAG declaration be taken care of too? "configure.cflags-append no-cpp-precomp", 'cause otherwise (as it is now) you're overriding the default CFLAGS we provide out of the box. Or is that intentional? (we have seen cases of default CFLAGS braking some builds due to, for instance, optimization).
Regards,...
-jmpp
That was not intentional, I've made your change in r27712. -- Anthony Ramine, a lazy french student. nox@macports.org
participants (2)
-
Juan Manuel Palacios
-
N_Ox