On Mar 17, 2008, at 12:47, reiffert@macports.org wrote:
Revision: 35110 http://trac.macosforge.org/projects/macports/changeset/35110 Author: reiffert@macports.org Date: 2008-03-17 10:47:47 -0700 (Mon, 17 Mar 2008)
Log Message: ----------- gnucash 2.2.4, fixing: #14297 (Update gnucash) #13316 (binreloc error) #13472 (Fails to build on leopard) #13852 (Fails to compile)
[snip]
-default_variants +guile16 +default_variants +guile16 +without-docs
-variant without_docs { +variant without_docs description {Does not build gnucash-docs} { depends_lib-delete port:gnucash-docs }
In the default variants, hyphen is not a valid character in variant names, and the variant is in fact named without_docs (with an underscore, not a hyphen). However, if you're going to make it the default to build without documentation, then the variant should be changed to be called "docs" (or "with_docs" if you insist on that nonstandard naming convention). Default variants are buggy during upgrades and should be avoided.
Thanks for pointing that out. Besides I'm currently fixing another problem along with gnucash: It doesnt find its docs. I'm actually getting closer to a solution, so I think I'll upload a new revision later this day. Kind regards Thomas Ryan Schmidt wrote:
On Mar 17, 2008, at 12:47, reiffert@macports.org wrote:
Revision: 35110 http://trac.macosforge.org/projects/macports/changeset/35110 Author: reiffert@macports.org Date: 2008-03-17 10:47:47 -0700 (Mon, 17 Mar 2008)
Log Message: ----------- gnucash 2.2.4, fixing: #14297 (Update gnucash) #13316 (binreloc error) #13472 (Fails to build on leopard) #13852 (Fails to compile)
[snip]
-default_variants +guile16 +default_variants +guile16 +without-docs
-variant without_docs { +variant without_docs description {Does not build gnucash-docs} { depends_lib-delete port:gnucash-docs }
In the default variants, hyphen is not a valid character in variant names, and the variant is in fact named without_docs (with an underscore, not a hyphen).
However, if you're going to make it the default to build without documentation, then the variant should be changed to be called "docs" (or "with_docs" if you insist on that nonstandard naming convention). Default variants are buggy during upgrades and should be avoided.
Ryan Schmidt wrote:
However, if you're going to make it the default to build without documentation, then the variant should be changed to be called "docs" (or "with_docs" if you insist on that nonstandard naming convention). Default variants are buggy during upgrades and should be avoided. ... Here also you'll want to instead convert the x11 variant to a no_x11 variant, and not use default_variants.
So, you think "default_variants" should be removed instead of fixed ? Or is this one of those interim workarounds, until upgrades work OK ? Does it work when not using "upgrade", but just deactivate/activate ? I hardly ever get upgrades to work at all, but that's probably just me. --anders
Anders F Björklund wrote:
Ryan Schmidt wrote:
However, if you're going to make it the default to build without documentation, then the variant should be changed to be called "docs" (or "with_docs" if you insist on that nonstandard naming convention). Default variants are buggy during upgrades and should be avoided. ... Here also you'll want to instead convert the x11 variant to a no_x11 variant, and not use default_variants.
So, you think "default_variants" should be removed instead of fixed ? Or is this one of those interim workarounds, until upgrades work OK ?
I also don't like these "no_*" variants, because they are semantically incorrect. And once we get this fixed we should rename these variants to get rid of the "no_" prefix. And that will cause some more trouble for people using them... But I neither know a better workaround at the moment, nor do I know how to fix it properly. Not sure what the fix would be; store deselected variants in the registry or remove default_variants when using upgrade. I think ticket #2377 [1] is related, although I can't find a ticket exactly for this default_variants problem. Maybe it does not include the right keywords? As our tickets are growing exponentially, it is not easy to find a specific ticket... Rainer [1] http://trac.macosforge.org/projects/macports/ticket/2377
participants (4)
-
Anders F Björklund
-
Rainer Müller
-
Ryan Schmidt
-
Thomas Reifferscheid