Re: [31434] trunk/dports/x11/gtk2/Portfile
On Fri, Nov 23, 2007 at 07:16:49AM -0800, rhwood@macports.org wrote:
Revision: 31434 http://trac.macosforge.org/projects/macports/changeset/31434 Author: rhwood@macports.org Date: 2007-11-23 07:16:47 -0800 (Fri, 23 Nov 2007)
Log Message: ----------- @#$% default variants! remove default variant add pre-fetch hook to error out if no variant is selected
This is breaking installs of wireshark (and I expect other ports that depend on gtk2) where the user doesn't have gtk2 installed already. Unless a mechanism to define the needed variant in the depspec has been added, can we revert this change, or otherwise set it so that x11 is the default? Thanks much, -eric
On Nov 29, 2007, at 14:01, Eric Hall wrote:
On Fri, Nov 23, 2007 at 07:16:49AM -0800, rhwood@macports.org wrote:
Revision: 31434 http://trac.macosforge.org/projects/macports/changeset/ 31434 Author: rhwood@macports.org Date: 2007-11-23 07:16:47 -0800 (Fri, 23 Nov 2007)
Log Message: ----------- @#$% default variants! remove default variant add pre-fetch hook to error out if no variant is selected
This is breaking installs of wireshark (and I expect other ports that depend on gtk2) where the user doesn't have gtk2 installed already. Unless a mechanism to define the needed variant in the depspec has been added, can we revert this change, or otherwise set it so that x11 is the default?
It's not *breaking* installs of wireshark, is it? It's just popping up a message that they must select either x11 or quartz, right? And if they then install gtk2 with x11 or quartz, they can install wireshark, right?
On Nov 29, 2007, at 3:09 PM, Ryan Schmidt wrote:
This is breaking installs of wireshark (and I expect other ports that depend on gtk2) where the user doesn't have gtk2 installed already. Unless a mechanism to define the needed variant in the depspec has been added, can we revert this change, or otherwise set it so that x11 is the default?
It's not *breaking* installs of wireshark, is it? It's just popping up a message that they must select either x11 or quartz, right? And if they then install gtk2 with x11 or quartz, they can install wireshark, right?
Well, it does break 'port install foo' which should probably always work (and install whatever the maintainer has decided the default set of features should be). -- Daniel J. Luke +========================================================+ | *---------------- dluke@geeklair.net ----------------* | | *-------------- http://www.geeklair.net -------------* | +========================================================+ | Opinions expressed are mine and do not necessarily | | reflect the opinions of my employer. | +========================================================+
On Thu, Nov 29, 2007 at 04:54:40PM -0500, Daniel J. Luke wrote:
On Nov 29, 2007, at 3:09 PM, Ryan Schmidt wrote:
This is breaking installs of wireshark (and I expect other ports that depend on gtk2) where the user doesn't have gtk2 installed already. Unless a mechanism to define the needed variant in the depspec has been added, can we revert this change, or otherwise set it so that x11 is the default?
It's not *breaking* installs of wireshark, is it? It's just popping up a message that they must select either x11 or quartz, right? And if they then install gtk2 with x11 or quartz, they can install wireshark, right?
Well, it does break 'port install foo' which should probably always work (and install whatever the maintainer has decided the default set of features should be).
Right, its not preventing someone from going through all the steps to install wireshark, it does break 'port install wireshark' (or foo) when the user hasn't already installed gtk2 (+x11, no idea how well +quartz works with wireshark). I agree that 'port install foo' should always work. If there's a way to specify 'gtk2 +x11' I'm all for adding that to the wireshark (and other) ports, I don't think there is yet (and I'm happy to be corrected). -eric
On Nov 29, 2007, at 4:52 PM, Eric Hall wrote:
If there's a way to specify 'gtk2 +x11' I'm all for adding that to the wireshark (and other) ports, I don't think there is yet (and I'm happy to be corrected).
The issue of specifying variants on deps is very very important to us here at NRAO, and I haven't figured out a way to do it yet. So if there's a way to do so, let me know how! Can't we just specify version and variant info in the depends list? example depends gtk2+x11 Alas this doesn't work as yet, but it would be the way to do it. It would also be nice to specify a version: depends gtk2@2.10.6+aqua Actually you'd want to specify an 'at least' version. Hmm. - boyd Boyd Waters Scientific Programmer National Radio Astronomy Observatory Socorro, New Mexico http://www.aoc.nrao.edu/~bwaters
The assumption that a user wants the entire X11 stack installed for him is not deterministically true. I will not and can not force a user to install X11 if they do not want to. On 29 Nov 2007, at 19:18, Boyd Waters wrote:
On Nov 29, 2007, at 4:52 PM, Eric Hall wrote:
If there's a way to specify 'gtk2 +x11' I'm all for adding that to the wireshark (and other) ports, I don't think there is yet (and I'm happy to be corrected).
The issue of specifying variants on deps is very very important to us here at NRAO, and I haven't figured out a way to do it yet.
So if there's a way to do so, let me know how!
Can't we just specify version and variant info in the depends list?
example
depends gtk2+x11
Alas this doesn't work as yet, but it would be the way to do it. It would also be nice to specify a version:
depends gtk2@2.10.6+aqua
Actually you'd want to specify an 'at least' version. Hmm.
- boyd
Boyd Waters Scientific Programmer National Radio Astronomy Observatory Socorro, New Mexico http://www.aoc.nrao.edu/~bwaters
_______________________________________________ macports-dev mailing list macports-dev@lists.macosforge.org http://lists.macosforge.org/mailman/listinfo/macports-dev
Randall Wood rhwood@mac.com http://shyramblings.blogspot.com "The rules are simple: The ball is round. The game lasts 90 minutes. All the rest is just philosophy."
On 30.11.2007, at 01:18, Boyd Waters wrote:
On Nov 29, 2007, at 4:52 PM, Eric Hall wrote:
If there's a way to specify 'gtk2 +x11' I'm all for adding that to the wireshark (and other) ports, I don't think there is yet (and I'm happy to be corrected).
The issue of specifying variants on deps is very very important to us here at NRAO, and I haven't figured out a way to do it yet.
So if there's a way to do so, let me know how!
Can't we just specify version and variant info in the depends list?
example
depends gtk2+x11
Alas this doesn't work as yet, but it would be the way to do it. It would also be nice to specify a version:
depends gtk2@2.10.6+aqua
Depending on variants is a bad idea imho: If A depends on B1 and C depends on B2 you get auto-trouble when trying to install both A and C. And there is no solution to get both installed and running - at all! When depending on variants, we get unsolvable dependency chains. If variant 1 and 2 of B are so important and so different, the best solution is to create two ports (that can be installed simultaneously). Either this or the default version of B should make both A and C happy. If someone wants to work on this, I'd rather suggest implementing port-inheritance, so that creating a "variant-port" is much easier and less work to maintain. Regards, -Markus --- Dipl. Inf. (FH) Markus W. Weissmann http://www.mweissmann.de/ http://www.macports.org/
On 30.11.2007, at 10:22, Randall Wood wrote:
The assumption that a user wants the entire X11 stack installed for him is not deterministically true. I will not and can not force a user to install X11 if they do not want to.
well, in reality there are two kind of users of macports: The ones who know exactly what they do and those who don't. The ones who know exactly what do to do not need hand-holding and can select quartz or x11 explicitly without getting slapped in the face. The ones who just want stuff to work don't know whats going on if a port -- that they don't care about as it's just a dependency of the stuff they want -- is auto-failing. You don't want to decide on topics you don't know about for reasons you neither know. If someone wants wireshark, he probably wants a working version of wireshark. He doesn't care if gtk uses quartz or x11 -- it has to work. I don't want to decide which compiler to use for every port, f they get built with or without UTF-8 support or if the pre-selected favorite background-color of xterm is purple or magenta. If someone does not want to have X11, he can use the quartz variant. Nobody is forcing him to use X11. -Markus PS: The current behaviour also prevents automated task on the gtk2 port, like mirroring and package-building: http://trac.macosforge.org/projects/macports/ticket/13442
On 29 Nov 2007, at 19:18, Boyd Waters wrote:
On Nov 29, 2007, at 4:52 PM, Eric Hall wrote:
If there's a way to specify 'gtk2 +x11' I'm all for adding that to the wireshark (and other) ports, I don't think there is yet (and I'm happy to be corrected).
The issue of specifying variants on deps is very very important to us here at NRAO, and I haven't figured out a way to do it yet.
So if there's a way to do so, let me know how!
Can't we just specify version and variant info in the depends list?
example
depends gtk2+x11
Alas this doesn't work as yet, but it would be the way to do it. It would also be nice to specify a version:
depends gtk2@2.10.6+aqua
Actually you'd want to specify an 'at least' version. Hmm.
- boyd
Boyd Waters Scientific Programmer National Radio Astronomy Observatory Socorro, New Mexico http://www.aoc.nrao.edu/~bwaters
_______________________________________________ macports-dev mailing list macports-dev@lists.macosforge.org http://lists.macosforge.org/mailman/listinfo/macports-dev
Randall Wood rhwood@mac.com http://shyramblings.blogspot.com
"The rules are simple: The ball is round. The game lasts 90 minutes. All the rest is just philosophy."
_______________________________________________ macports-dev mailing list macports-dev@lists.macosforge.org http://lists.macosforge.org/mailman/listinfo/macports-dev
--- Dipl. Inf. (FH) Markus W. Weissmann http://www.mweissmann.de/ http://www.macports.org/
On Fri, Nov 30, 2007 at 04:22:12AM -0500, Randall Wood wrote:
The assumption that a user wants the entire X11 stack installed for him is not deterministically true. I will not and can not force a user to install X11 if they do not want to.
I agree, we can't (always) know that a user wants X11 intalled. As Marcus pointed out, there are users who know what they want, and they tend to be the folks who know what to do to get it (or can figure it out). There are the other users (which to me includes the automated builds) that just want it to work(tm). Perhaps the best compromise would be to have a message pop up indicating that the gtk2 port is capable of being installed with +x11 or +quartz (in wording that people understand) and will default to +x11 in $SECONDS and what to do to stop it and go back to install with +quartz if that's what they want. If port can also tell if it is going to go build all of X11 (vs it being installed already, as is the default for Leopard), that'd be great. I think this would let people who know and/or are interested get what they want (+quartz) and also allow automated and "I don't know/care" installs to succeed. What do you think about this? Improvements or other ideas? -eric
On Fri, Nov 30, 2007 at 07:06:18PM +0000, Eric Hall wrote:
On Fri, Nov 30, 2007 at 04:22:12AM -0500, Randall Wood wrote:
The assumption that a user wants the entire X11 stack installed for him is not deterministically true. I will not and can not force a user to install X11 if they do not want to.
I agree, we can't (always) know that a user wants X11 intalled. As Marcus pointed out, there are users who know what they want, ^^^^^^ Err, Markus, sorry about that.
Le 07-11-30 à 14:06, Eric Hall a écrit :
On Fri, Nov 30, 2007 at 04:22:12AM -0500, Randall Wood wrote:
The assumption that a user wants the entire X11 stack installed for him is not deterministically true. I will not and can not force a user to install X11 if they do not want to.
I agree, we can't (always) know that a user wants X11 intalled. As Marcus pointed out, there are users who know what they want, and they tend to be the folks who know what to do to get it (or can figure it out). There are the other users (which to me includes the automated builds) that just want it to work(tm). Perhaps the best compromise would be to have a message pop up indicating that the gtk2 port is capable of being installed with +x11 or +quartz (in wording that people understand) and will default to +x11 in $SECONDS and what to do to stop it and go back to install with +quartz if that's what they want. If port can also tell if it is going to go build all of X11 (vs it being installed already, as is the default for Leopard), that'd be great. I think this would let people who know and/or are interested get what they want (+quartz) and also allow automated and "I don't know/care" installs to succeed. What do you think about this? Improvements or other ideas?
This gtk2 message should indicate clearly that most ports will fail at runtime with +quartz yves
participants (7)
-
Boyd Waters
-
Daniel J. Luke
-
Eric Hall
-
Randall Wood
-
Ryan Schmidt
-
Weissmann Markus
-
Yves de Champlain