Re: [31448] trunk/dports/mail/t-prot/Portfile
On Sat, Nov 24, 2007 at 04:59:11AM -0800, simon@macports.org wrote:
Revision: 31448 http://trac.macosforge.org/projects/macports/changeset/31448 Author: simon@macports.org Date: 2007-11-24 04:59:01 -0800 (Sat, 24 Nov 2007)
Log Message: ----------- mail/t-prot: Whitespace only change to follow conventions.
Modified Paths: -------------- trunk/dports/mail/t-prot/Portfile
I also removed the cd command to make it work with macports 1.6. I forgot to add this to the commit log. Simon -- + privacy is necessary + using http://gnupg.org + public key id: 0x6115F804EFB33229
On Nov 24, 2007, at 07:13, Simon Ruderich wrote:
On Sat, Nov 24, 2007 at 04:59:11AM -0800, simon@macports.org wrote:
Revision: 31448 http://trac.macosforge.org/projects/macports/changeset/ 31448 Author: simon@macports.org Date: 2007-11-24 04:59:01 -0800 (Sat, 24 Nov 2007)
Log Message: ----------- mail/t-prot: Whitespace only change to follow conventions.
Modified Paths: -------------- trunk/dports/mail/t-prot/Portfile
I also removed the cd command to make it work with macports 1.6. I forgot to add this to the commit log.
Then you should fix the log message with: svn propedit --revprop -r 31448 svn:log http://svn.macosforge.org/ repository/macports When you edit the property, mail is not currently sent to the changes mailing list, nor is the change picked up by Trac. However, I hope that will change in the future through the installation of a post- revprop-change hook.
On Sat, Nov 24, 2007 at 08:36:08AM -0600, Ryan Schmidt wrote:
Then you should fix the log message with:
svn propedit --revprop -r 31448 svn:log http://svn.macosforge.org/repository/macports
When you edit the property, mail is not currently sent to the changes mailing list, nor is the change picked up by Trac. However, I hope that will change in the future through the installation of a post-revprop-change hook.
Thanks for the hint, I fixed it. But the change is not showing up in Trac and svn log. But if I do "propedit" again it is displayed correctly. Thanks, Simon -- + privacy is necessary + using http://gnupg.org + public key id: 0x6115F804EFB33229
On Nov 24, 2007, at 09:09, Simon Ruderich wrote:
On Sat, Nov 24, 2007 at 08:36:08AM -0600, Ryan Schmidt wrote:
Then you should fix the log message with:
svn propedit --revprop -r 31448 svn:log http://svn.macosforge.org/repository/macports
When you edit the property, mail is not currently sent to the changes mailing list, nor is the change picked up by Trac. However, I hope that will change in the future through the installation of a post-revprop- change hook.
Thanks for the hint, I fixed it.
But the change is not showing up in Trac and svn log. But if I do "propedit" again it is displayed correctly.
Right, like I said, Trac won't pick up the change, until we write and install a post-revprop-change hook into the repository to do that. "svn log" on the command line does show the change. Note that MacPorts 1.6 will still include the cd command; its removal has been deferred to 1.7 due to the high number of ports still using the cd command.
On Nov 24, 2007, at 10:36 AM, Ryan Schmidt wrote:
On Nov 24, 2007, at 07:13, Simon Ruderich wrote:
On Sat, Nov 24, 2007 at 04:59:11AM -0800, simon@macports.org wrote:
Revision: 31448 http://trac.macosforge.org/projects/macports/changeset/ 31448 Author: simon@macports.org Date: 2007-11-24 04:59:01 -0800 (Sat, 24 Nov 2007)
Log Message: ----------- mail/t-prot: Whitespace only change to follow conventions.
Modified Paths: -------------- trunk/dports/mail/t-prot/Portfile
I also removed the cd command to make it work with macports 1.6. I forgot to add this to the commit log.
Then you should fix the log message with:
svn propedit --revprop -r 31448 svn:log http://svn.macosforge.org/repository/macports
When you edit the property, mail is not currently sent to the changes mailing list, nor is the change picked up by Trac. However, I hope that will change in the future through the installation of a post-revprop-change hook.
Bill already implemented this for us and the corresponding ticket was closed, #12593. Sorry that I forgot to announce it, Bill has been delivering quite a few goodies for us lately ;-) The hook may be incomplete, however; we were discussing a few things and (like the From and Reply-To fields of message headers) and he jotted down our conclusions and said he'd get to them later, as it was late at night at the moment and thanksgiving week was dawning on them. So the hook should now work, even if not 100%, and probably this is a good time to test it. -jmpp
On Nov 24, 2007, at 11:40 AM, Ryan Schmidt wrote:
On Nov 24, 2007, at 09:09, Simon Ruderich wrote:
On Sat, Nov 24, 2007 at 08:36:08AM -0600, Ryan Schmidt wrote:
Then you should fix the log message with:
svn propedit --revprop -r 31448 svn:log http://svn.macosforge.org/repository/macports
When you edit the property, mail is not currently sent to the changes mailing list, nor is the change picked up by Trac. However, I hope that will change in the future through the installation of a post-revprop- change hook.
Thanks for the hint, I fixed it.
But the change is not showing up in Trac and svn log. But if I do "propedit" again it is displayed correctly.
Right, like I said, Trac won't pick up the change, until we write and install a post-revprop-change hook into the repository to do that.
"svn log" on the command line does show the change.
Hhhmmmm, seems like it's not working, but Bill did install the hook (OK, I wasn't *there* to see it, but I certainly was chatting with him as we were taking care of a few things ;-). I'll ask him about it this coming week.
Note that MacPorts 1.6 will still include the cd command; its removal has been deferred to 1.7 due to the high number of ports still using the cd command.
Hopefully before 1.7 ;-) -jmpp
On Sat, Nov 24, 2007 at 09:40:58AM -0600, Ryan Schmidt wrote:
Right, like I said, Trac won't pick up the change, until we write and install a post-revprop-change hook into the repository to do that.
"svn log" on the command line does show the change.
I checked again, and you are right, it does. I was looking at the wrong revision ..
Note that MacPorts 1.6 will still include the cd command; its removal has been deferred to 1.7 due to the high number of ports still using the cd command.
Good to know, thanks. I'm using trunk and as it failed I fixed it to be sure. Thanks, Simon -- + privacy is necessary + using http://gnupg.org + public key id: 0x6115F804EFB33229
participants (3)
-
Juan Manuel Palacios
-
Ryan Schmidt
-
Simon Ruderich