#40516: Two new variants + text editor modeline --------------------------+--------------------------- Reporter: jpolmsted@… | Owner: kjell.konis@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: R | --------------------------+--------------------------- Comment (by jpolmsted@…): Replying to [comment:4 larryv@…]:
Replying to [comment:3 jpolmsted@…]:
I'm confused about the opposition. This is the behavior intended by me and seems completely consistent with the test phase. Am I missing something? Under this setup, checking is optional (as it is with a manual install) and it happens after the build and before the install.
This is not true; the test phase is //not// run during a port installation, even if the Portfile sets `test.run yes`. Users would already have to explicitly run the tests with `port test R`, so they should not have to select a variant on top of that.
Thanks, that makes sense. I'll update the patch tomorrow to be consistent with `port test R` usage.
From an R user's perspective, I don't think there is a downside. It just copies files to the installation prefix that already exist and can be used.
Hm. If installing the tests isn’t terribly inconvenient (build time, disk space, etc.), then they should probably always be installed.
I don't disagree, but I'll err on the side of the R developers here. They didn't (and still don't) choose to include them. But the port maintainer can easily change it if wanted. -- Ticket URL: <https://trac.macports.org/ticket/40516#comment:5> MacPorts <http://www.macports.org/> Ports system for OS X