#43568: zathura @0.2.7 --------------------------+-------------------------------- Reporter: starkhalo@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.2.1 Resolution: | Keywords: Port: zathura | --------------------------+-------------------------------- Comment (by starkhalo@…): Replying to [comment:2 ryandesign@…]:
Thanks. Some observations:
* There should be a blank line between the "`# $Id$`" and "`PortSystem 1.0`" lines. Done.
* The license field should be just "`zlib`", not "`zlib License`". Done.
* The line "`distname zathura-${version}`" should be removed because that is the default value. Done.
* The distfile name should be removed from the checksums line because there is only one file being checksummed. Done.
* Because you use "`use_configure no`", you must add code to ensure you're UsingTheRightCompiler, building with `-arch` flags, and if possible add a universal variant.
-- ''UsingTheRightCompiler'' I have checked the Makefile and it uses ${CC}, I also added the recommended lines for ''Ports with nonstandard or non-existent configure scripts'' https://trac.macports.org/wiki/UsingTheRightCompiler #nonstandard-ports -- ''build with `-arch- flags`'' Is this not handled by default? -- ''add a universal variant'' Why? §5.3.7.1 ''Configure Universal'' ''There is a default universal variant made available to all ports by MacPorts base, so redefining universal keywords '''should only be done''' to make a given port compile '''if''' the default options fail to do so.''
* The dependency on glib2 should be written as a path-style dependency so that glib2-devel could satisfy it; see other ports depending on glib2 for how to do that. Went with `depends_lib path:lib/libglib-2.0.dylib:glib2`
* The dependency on girara should be written in port-style, not lib- style, unless there is an unusual requirement here that I'm not aware of. Rewritten in `path:` style.
* You could use the ${homepage} variable in the definition of master_sites. Done.
-- Ticket URL: <https://trac.macports.org/ticket/43568#comment:3> MacPorts <http://www.macports.org/> Ports system for OS X