#44526: xxdiff: update to 4.0 --------------------------+-------------------------------- Reporter: rjvbertin@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: xxdiff | --------------------------+-------------------------------- Comment (by ryandesign@…): Some observations: * One should not both declare "`use_configure no`" and define a "`configure`" block. * Do you really need to override the configure phase to run `qmake`? The point of the qmake 1.0 portgroup is to automate that for you. * One should not "`system "cd ...; ..."`"; one should instead "`system -W ... "..."`". * "`file copy`" can be shortened to "`copy`" and "`file delete`" can be shortened to "`delete`". * Is there a reason why the documentation needs to be moved to a doc variant? Variants should be added sparingly and when absolutely necessary. -- Ticket URL: <https://trac.macports.org/ticket/44526#comment:5> MacPorts <http://www.macports.org/> Ports system for OS X