#44296: ROOT5 : Update to 5.34.19 -----------------------+--------------------------------- Reporter: jonesc@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch maintainer Port: root5 | -----------------------+--------------------------------- Comment (by jonesc@…): Replying to [comment:1 mojca@…]:
Just a few questions before committing: * Did you plan to include some code related to the (conflicting) python variants?
I don't think anything needs updating in the root5 port for this... It should not have the same issues as the root6 port has. ... Or has my memory missed something ?
* We might want to address ticket #44224 (maybe by blacklisting compilers), but I'm not sure how and it's low priority anyway.
I also do not know how...
* Somewhere on the "TODO" list I have the following chunk of code left (probably it needs to be tested and compared with ROOT 6): {{{ +# make sure that the proper variant is automatically selected +# (ROOT crashes if the compiler it was built with doesn't exist) +if {![variant_isset clang33] && ![variant_isset clang34] && ![variant_isset clang35]} { + if { ${configure.compiler} eq "macports-clang-3.3" } { + default_variants-append +clang33 + } elseif { ${configure.compiler} eq "macports-clang-3.4" } { + default_variants-append +clang34 + } elseif { ${configure.compiler} eq "macports-clang-3.5" } { + default_variants-append +clang35 + } +} }}}
Yeah, I guess this could be included. I confess I did forget this. Please feel free to add it if you like... Its less important I think as root5 does not use any macports clang compiler by default, due to blacklists etc. So I think in practise hardly any uses will use it, and then probably via the variant anyway. Chris -- Ticket URL: <https://trac.macports.org/ticket/44296#comment:3> MacPorts <http://www.macports.org/> Ports system for OS X