#41077: mod_jk fails with "source and destination buffer overlap" on Maverick -----------------------+-------------------------------- Reporter: girgen@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.2.1 Resolution: | Keywords: mavericks haspatch Port: mod_jk | -----------------------+-------------------------------- Comment (by raimue@…): The statement {{{ set javahome [exec /usr/libexec/java_home] }}} looks wrong to me. What if there is no Java SDK installed on the system? Won't this lead to an error here? Could it be a shim that pops up the automatic installation dialog? Or is it guaranteed that his binary always exists on all versions of Mac OS X? Not sure what to make of this. Furthermore, the whole detection seems to be required for the +jni variant, which probably links against the Java runtime specified with `${javahome}`. But what happens if I change the system default Java runtime? I am aware this issue existed before this change, just writing down what I see as I am looking at the port. Upstream raised [https://issues.apache.org/bugzilla/show_bug.cgi?id=55696#c11 some concerns] about the use of strncpy(3) in the patch. I agree with them and would recommend to use strlcpy(3), which would most probably not be portable to Linux/glibc, but works fine on various *BSD versions and OS X. Updated patch attached. -- Ticket URL: <https://trac.macports.org/ticket/41077#comment:6> MacPorts <http://www.macports.org/> Ports system for OS X