#39773: nginx 1.4.1 build failures with +upload, +google_perftools ------------------------------+---------------------- Reporter: anthropologoi@… | Owner: cal@… Type: defect | Status: closed Priority: Normal | Milestone: Component: ports | Version: 2.1.3 Resolution: fixed | Keywords: haspatch Port: nginx | ------------------------------+---------------------- Changes (by cal@…): * status: new => closed * resolution: => fixed Comment: - Committed the fix for the upload module in r108280 with the following change: Avoided the rev-bump, I'll update to 1.4.2 soon anyway - The `upvar` code is fine and actually a nice solution to a problem we often see. We're using Tcl anyway, so why not make use of its features to solve problems? :) - Committed the cleanup for `+upload_progress` in r108281. - Committed the warning regarding `google_perftools` in r108283 with the following changes: - Abort with an error message instead of printing a warning and continuing without the configure flag. A user should consciously disable the variant if he knows it won't work and wants to continue installing nginx without it. - Move the check to a `pre-configure` phase. The `google_perftools` might not be installed before configure, causing the check to fail. Thanks for the patches. -- Ticket URL: <https://trac.macports.org/ticket/39773#comment:3> MacPorts <http://www.macports.org/> Ports system for OS X