#41069: file @5.15_0 gives errors instead of a result ----------------------+-------------------------- Reporter: ralph@… | Owner: ryandesign@… Type: defect | Status: closed Priority: Normal | Milestone: Component: ports | Version: 2.2.0 Resolution: fixed | Keywords: Port: file | ----------------------+-------------------------- Comment (by ryandesign@…): Replying to [comment:21 kimmo@…]:
Unfortunately it introduces a new problem, which affects the output of many cases, for example PNG files. You may want to add this patch until 5.19 comes out: https://raw.githubusercontent.com/suominen/macports- gw/master/sysutils/file/files/patch-post-518.diff
Thanks, I've committed that in r118485. Replying to [comment:16 kimmo@…]:
- patch-magic-Magdir-msdos.diff: having file produce different results depending on which packaging system was used seems very undesirable to me. However, a change like this would definitely be appropriate to bring up on the file mailing list or bug tracker.
r41083 “patch the magic information to fix a bogus entry"
Yes, I can see the reasoning. The magic for office files is non-trivial and has been discussed quite a bit on the developers list. (And I'm not expert in it.)
I just feel that this kind of a modification to file is undesirable, as it means that file from MacPorts then gives different results from all other installations of file. If this results in someone reporting an issue to the file developers, it is annoying to realize it is different just due to the packaging system used.
I would encourage getting it fixed upstream, but I feel I don't have enough understanding of office file formats to pursue it myself. (Sorry.)
That said, I'll leave it to the owner of the package to decide how to maintain it. :)
I've also removed this patch. Anyone interested in having this change back can convince the developers to add it to their sources. -- Ticket URL: <https://trac.macports.org/ticket/41069#comment:24> MacPorts <http://www.macports.org/> Ports system for OS X