#29676: Fix mtree violation for Puppet and update to 2.6.8 --------------------------------------+------------------------------------- Reporter: nigel@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Keywords: haspatch maintainer | Port: puppet --------------------------------------+------------------------------------- Comment(by ryandesign@…): Using the patch from #15514, I get: {{{ Warning: reinplace s|/etc/puppet|/opt/local/etc/puppet| didn't change anything in /opt/local/var/macports/build/_Users_rschmidt_macports_dports_sysutils_puppet/work/puppet-2.6.8/lib/puppet/defaults.rb Warning: reinplace s|$confdir/ssl|/opt/local/var/puppet/ssl| didn't change anything in /opt/local/var/macports/build/_Users_rschmidt_macports_dports_sysutils_puppet/work/puppet-2.6.8/lib/puppet/defaults.rb }}} So I think some of those reinplaces aren't necessary, or need to be different. There also doesn't seem to be a reason to use the `-E` flag for reinplace. In fact, if I remove it, only one warning is printed: {{{ Warning: reinplace s|/etc/puppet|/opt/local/etc/puppet| didn't change anything in /opt/local/var/macports/build/_Users_rschmidt_macports_dports_sysutils_puppet/work/puppet-2.6.8/lib/puppet/defaults.rb }}} These reinplaces are a bit prone to breaking in the future and leaving it unclear to the next person to try to update the port how to do so. It might be clearer if you write patchfiles that first insert the correct paths into the files, with the @PREFIX@ placeholder, and then just use reinplace to replace @PREFIX@ with ${prefix}. Finally, the post-destroot block doesn't do anything. It creates a directory, but since nothing is in that directory, MacPorts will delete it before the port install finishes. The solution, if you want the directory kept, is to add a `destroot.keepdirs` line. -- Ticket URL: <https://trac.macports.org/ticket/29676#comment:4> MacPorts <http://www.macports.org/> Ports system for Mac OS