#15090: vobcopy-1.1.1 new port ---------------------------------------+------------------------------------ Reporter: 0booo5b02@sneakemail.com | Owner: macports-tickets@lists.macosforge.org Type: enhancement | Status: new Priority: Normal | Milestone: Port Submissions Component: ports | Version: 1.6.0 Resolution: | Keywords: ---------------------------------------+------------------------------------ Comment (by 0booo5b02@sneakemail.com): Replying to [comment:1 jmr@macports.org]:
Some suggested changes to the Portfile: * You can obfuscate your email address to help thwart spam harvesters, like so: `sneakemail.com:0booo5b02`. The output from 'port info' will still be the same.
The email is already obfuscated (hence the sneakemail.com domain) but thanks. Besides that, it is displayed in plaintext in this very page.
* You should use ${prefix} instead of hardcoding /opt/local in `--with- dvdread-libs=/opt/local`. You also don't need to specify `--prefix=${prefix}` in configure.args, since it is automatically set in configure.pre_args.
I missed that one. Done
* Since you're specifying the path to MacPorts' libdvdread, you don't want the dependency satisfied by something installed somewhere else, so you should use `port:libdvdread` rather than `lib:libdvdread:libdvdread`.
I suspected this but wasn't sure so I decided to keep it as in the port in which I based this one. Done.
* The `cd` command is deprecated, so don't use it. You should also generally use the built-in Tcl command `file link -symbolic` rather than calling ln via the system command. However, these points are actually irrelevant in this case, since you don't need the pre-configure phase. You can just use `configure.cmd configure.sh`.
I missed this `configure.cmd in the documentation but configure.sh doesn't work, it needs to be set to ./configure.sh Done configure.cmd is only mentioned in relation to configure.args, configure.pre_args, configure.post_args. Maybe having its own entry in the documentation would be a good idea. New Portfile attached This was my first port for this system so thank you for your suggestions and help. -- Ticket URL: <http://trac.macosforge.org/projects/macports/ticket/15090#comment:2> MacPorts </projects/macports> Ports system for Mac OS