#43579: zathura-plugin-pdf-poppler @0.2.7 -----------------------------------------+-------------------------------- Reporter: starkhalo@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.2.1 Resolution: | Keywords: pwmt Port: zathura-plugin-pdf-poppler | -----------------------------------------+-------------------------------- Comment (by ryandesign@…): Thanks. Some observations about the Portfile: * There should be a blank line between the "`# $Id$`" line and the "`PortSystem 1.0`" line; running "`port lint --nitpick`" should mention that. * The license field should be just "`zlib`", not "`zlib License`" (the license field is a space-separated list of values; consult the port_binary_distributable.tcl script for a non-exhaustive list of license names) * Checksums are not used for patchfiles that will be copied to the files directory; they are used for patchfiles that get downloaded, but we only do that in the very unusual circumstance that a patchfile is provided by a third party and it is too large to be conveniently copied into the files directory. * The checksums line doesn't need to mention the distfile name, because there is only one file being checksummed. * Patchfile names should be of the form "patch-*.diff", as "`port lint --nitpick`" should mention. * Because use you "`use_configure no`", you must add code to ensure you're UsingTheRightCompiler, build with `-arch` flags, and if possible add a universal variant. * lib- and bin-style dependencies allow non-MacPorts software to satisfy them. We don't normally want that; see wiki:FAQ. So usually you should use port-style dependencies (if only a single port exists that can satisfy it), or path-style dependencies (if there are multiple ports that can satisfy it). Or if there is another reason why you used lib- and bin-style dependencies in this port, let me know. Regarding patch-Makefile: * The install_name of a library should be the final location of the library when it is installed; it should not begin with ${DESTDIR} * The install_name should usually be set using the "`-install_name`" flag; is there a particular reason you used "`-Wl,-dylib_install_name,`" instead? -- Ticket URL: <https://trac.macports.org/ticket/43579#comment:2> MacPorts <http://www.macports.org/> Ports system for OS X