#41069: file @5.15_0 gives errors instead of a result ----------------------+-------------------------- Reporter: ralph@… | Owner: ryandesign@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.2.0 Resolution: | Keywords: Port: file | ----------------------+-------------------------- Comment (by jmr@…): Replying to [comment:12 kimmo@…]:
Here are my thoughts on the patches, without having an easy way of knowing why they really were added originally.
You can view the commit logs for the patchfiles in Trac.
- patch-getline.diff: this seems unnecessary; the binary is linked correctly and runs without the change
r102948 "Fix build on Snow Leopard"
- patch-magic-Magdir-msdos.diff: having file produce different results depending on which packaging system was used seems very undesirable to me. However, a change like this would definitely be appropriate to bring up on the file mailing list or bug tracker.
r41083 “patch the magic information to fix a bogus entry"
- patch-magic-Makefile.am: an uncompiled collection of the magic entries is not needed, but I could see how it might be interesting as a reference. Was that the reason for the patch? I think proposing this upstream with the reasoning behind it would also be good.
r41083 “add a variant that installs the plain-text magic(5) file” No real insight from that last one, but apparently at least one person uses it since they filed #23710. -- Ticket URL: <https://trac.macports.org/ticket/41069#comment:14> MacPorts <http://www.macports.org/> Ports system for OS X