#48413: py-horton @2.0.0 Quantum_chemistry_python_package -------------------------+-------------------------------- Reporter: yangx59@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: py-horton | -------------------------+-------------------------------- Comment (by yangx59@…): Replying to [comment:13 raimue@…]:
As this port also provides scripts that are meant to be called by users, it would probably make more sense to name it simply `horton`. The `py-*` prefix is used for python modules that are only referenced as library. Also I recommend to put this port into the primary category `science`.
The `ui_warn` in the post-activate phase should be converted to port notes. It might get lost during installations this way, notes are all shown at the end of the install/update process of all ports. I think the intention was to only show this message if py27-numpy +atlas was not an active variant, but notes will be saved before the activate phase, so that needs to go into a pre-activate phase. Also, any markers to draw additional attention such as these asterisks are discouraged.
{{{ pre-activate { if {![active_variants py27-numpy atlas]} { notes { In order to have CHOLESKY work properly, ... } } } }}}
Also if py27-numpy was already installed, the given install command does not work. It requires an upgrade with the new variant, that would be: `sudo port -n upgrade --enforce-variants py27-numpy +atlas`.
Thank you for your review. I changed the category to science, changed the ui_warn into notes. These changes do make the information looks better rather than the asterisks. Fot the name I am a little bit hesitate because our package is still a python module and right now only for python27. It works like a library, but it takes a little bit complicated steps to install. So I still prefer its name to be py27-horton so users can understand this is still a python package other than a individual software. I upload the latest Portfile 1.1 in the attachment. -- Ticket URL: <https://trac.macports.org/ticket/48413#comment:15> MacPorts <https://www.macports.org/> Ports system for OS X