#40782: wireshark-devel: update to 1.11.0 ------------------------------+----------------------- Reporter: ryandesign@… | Owner: hsivank@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: wireshark-devel | ------------------------------+----------------------- Comment (by mojca@…): Replying to [comment:31 hsivank@…]:
Replying to [comment:30 mojca@…]:
* `checksums`: you should use `rmd160` and `sha256`. You may remove `md5` and `sha1`. I would prefer *official* wireshark hash (md5,sha1,ripemd160) : https://www.wireshark.org/download/src/all-versions/SIGNATURES-1.99.8.txt
What if you just add sha256 then?
{{{ default_variants +portaudio +zlib +lua +libsmi +gnutls +libgcrypt +cares +geoip
if {![variant_isset qt4] && ![variant_isset qt5] && ![variant_isset gtk2] && ![variant_isset gtk3] && ![variant_isset no_gui]} { default_variants +qt5 } }}} Is it correct ?
Yes, I think so. (Unless you invert `no_gui` into `gui` of course.) Just for fun I tried what it meant switching to `+gui`. The weird fact is that with the usage of {{{ default_variants +portaudio +zlib +lua +libsmi +gnutls +libgcrypt +cares +geoip +gui if {[variant_isset gui]} { if {![variant_isset qt4] && ![variant_isset qt5] && ![variant_isset gtk2] && ![variant_isset gtk3]} { default_variants +qt5 } } variant qt5 requires gui conflicts qt4 gtk2 gtk3 description {Build Wireshark} {...} }}} MacPorts should complain when using {{{ port -v configure wireshark-devel -gui +qt5 }}} But it doesn't. I'm wondering if this is a bug in MacPorts.
* enable things like lua and zlib by default Maybe i'm missing something but zlib and lua are already enabled by default
{{{ default_variants ... +zlib +lua ... }}}
Sorry, I meant unconditionally enable them (not even giving the users any choice). Both dependencies are very small and I'm not sure if it brings any added value to the port to allow turning those variants off. But that was just a suggestion that you don't need to follow. -- Ticket URL: <https://trac.macports.org/ticket/40782#comment:33> MacPorts <https://www.macports.org/> Ports system for OS X