#24234: Update cln from 1.2.2 to 1.3.1 --------------------------------------------+------------------------------- Reporter: danmichaelo+macports@… | Owner: gwright@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Keywords: haspatch | Port: cln --------------------------------------------+------------------------------- Changes (by ryandesign@…): * cc: ryandesign@… (added) Comment: Replying to [ticket:24234 danmichaelo+macports@…]:
I provide a patch for updating to version 1.3.1.
[attachment:Portfile-cln.diff The patch] is not acceptable as-is because it makes whitespace changes to the entire portfile. Please either supply diffs that make exclusively whitespace changes, or that make functional changes that respect the portfile's existing whitespace conventions. [attachment:cln.diff Attached is a patch] that I believe represents the functional changes you're proposing while preserving the portfile's existing whitespace. Your changes amount to updating the version and checksums, changing the description and long description, and modifying the optimization flags. The latter concerns me because a) removing "-03" from the cflags doesn't make sense because "-O3" is not in the cflags by default; "-O2" is; and b) having "-O2" in the cflags apparently makes the test suite fail -- at least, that's why this was originally changed in r38679; I haven't yet tested to verify whether that was the case, or whether it continues to be the case now with 1.3.1. If you have already verified that this is no longer a problem, please let us know.
I can't get universal build to work with either version 1.2.2 or 1.3.1, so I added "universal_variant no".
I filed #24674 for this issue. -- Ticket URL: <http://trac.macports.org/ticket/24234#comment:2> MacPorts <http://www.macports.org/> Ports system for Mac OS