#40742: py-PyQGLViewer @0.11 submission ----------------------------------+-------------------------------- Reporter: christophe.pradal@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.2.0 Resolution: | Keywords: Port: py-PyQGLViewer | ----------------------------------+-------------------------------- Comment (by christophe.pradal@…): Replying to [comment:2 ryandesign@…]: Thanks a lot for the very fast review. I have fixed the errors in the file Portfile.2
Thanks. Some observations: * Since you are not a committer, the maintainers line must list your complete email address in our obfuscated host:user format. Done: Change pradal into inria.fr:christophe.pradal
* "eq" should be used for string comparisons instead of "!=". Done. Change != into ne
* configure.pre_args is meant only for specifying the prefix; other arguments should go in configure.args. Done. To remove the --prefix in the configure, I let the configure.pre_args empty. Other args are defined in configure.args
* "-I /opt/X11/include" should not be specified; MacPorts ports shall not use XQuartz or other non-MacPorts X11 implementations. If this port needs something from X11, it should declare a dependency on the appropriate xorg port. Fixed. X11 is only needed with qt4-x11 and is not used currently.
-- Ticket URL: <https://trac.macports.org/ticket/40742#comment:3> MacPorts <http://www.macports.org/> Ports system for OS X