#33575: stimfit -----------------------------+---------------------------------------------- Reporter: christsc@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: Keywords: | Port: stimfit -----------------------------+---------------------------------------------- Comment(by christsc@…): Thanks for your review. Replying to [comment:1 macsforever2000@…]:
Looks good but I have a few comments: 1. It is preferable if you allow the user to choose the python version by making variants for python26, python27, python31, etc. You can make python27 the default. See the inkscape port for an example.
There's no python26 port for wxpython-devel yet. I've started a ticket ([http://trac.macports.org/ticket/33590 #33590]). Pending its acceptance, the python26 variant is commented out.
2. Use {{{${applications_dir}}}} instead of hardcoding {{{/Applications/Macports}}} in post-destroot.
Done. The app bundle now gets installed to {{{${destroot}${applications_dir}}}} so that uninstall can clean up properly. -- Ticket URL: <https://trac.macports.org/ticket/33575#comment:2> MacPorts <http://www.macports.org/> Ports system for Mac OS