#46359: kde4-workspace: update to 4.11.14 -----------------------------+------------------------- Reporter: nicos@… | Owner: rjvbertin@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: kde4-workspace | -----------------------------+------------------------- Comment (by nicos@…): There several things which seem to require corrections in my point of view: - You removed the use of plasmaversion, to directly use the kde-workspace version. This would require an increase of epoch for users to see the upgrade. - The revision field is unneeded for an upgrade - The emails should be encoded with :, as it is in the Portfile - The line {{{ if { [variant_isset nostrip] } { }}} is unneeded, as the existing code in the Portfile does that already. - The variants in no_foo or without_foo should not be added, and replaced by +foo. - In the without_oxygen variant, you delete the use of a patch which is never included. - Why suppressing the livecheck? -- Ticket URL: <https://trac.macports.org/ticket/46359#comment:3> MacPorts <https://www.macports.org/> Ports system for OS X