#40782: wireshark-devel: update to 1.11.0 ------------------------------+----------------------- Reporter: ryandesign@… | Owner: hsivank@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: wireshark-devel | ------------------------------+----------------------- Comment (by macports@…): Replying to [comment:26 hsivank@…]:
Updated my previous Portfile with cmake support and clean variant description [...]
[[br]]Some comments about this patch: Variants: - Python support has been removed, so those variants are setting configure options which are being ignored. - There is no use setting both cares and adns as default variants, only one of them will be applied. - Setting qt5 as a default variant makes it impossible to build with qt4, since they conflict. An "if" is needed:[[br]] {{{ if {![variant_isset qt]} { default_variants +qt5 } }}} - The wireshark port offers variants to enable or disable ipv6 and ssl, kerberos5 is enabled by default and variants gtk2 and portaudio are named x11 and rtp respectively. It may be good to offer compatible variants so that this port can be used as a drop-in replacement once wireshark 1.99 becomes the stable build. - There is an error at line 182, for variant geoip, where you wrote kerberos5 instead. Dependencies: - Variant gtk3 is missing a dependency for port:adwaita-icon-theme, which I had added in my patch. - "depends_lib port:openssl" on line 40 is reverting the patch made in changeset 139229: https://trac.macports.org/changeset/139229/trunk/dports/net/wireshark- devel/Portfile Changes: - These calls:[[br]]"eval xinstall -m 644 [glob ${worksrcpath}/epan/*.h] ${destroot}${prefix}/include/wireshark/epan/"[[br]]should look like this: [[br]]"xinstall -m 644 {*}[glob ${worksrcpath}/epan/*.h] ${destroot}${prefix}/include/wireshark/epan/" (see #48363, comment #1). Application Launcher: - As I noted in #48363, comment #9, this patch does not create launchers in the Application folder for the gtk2 and gtk3 variants. - For qt4/qt5, the application launcher created starts with a lowercase w, while the convention is to have it uppercase. -- Ticket URL: <https://trac.macports.org/ticket/40782#comment:27> MacPorts <https://www.macports.org/> Ports system for OS X