#16238: Port for MapServer --------------------------------------+------------------------------------- Reporter: mbarchfe@googlemail.com | Owner: macports-tickets@lists.macosforge.org Type: enhancement | Status: new Priority: Normal | Milestone: Port Submissions Component: ports | Version: 1.6.0 Resolution: | Keywords: --------------------------------------+------------------------------------- Changes (by ryandesign@macports.org): * cc: ryandesign@macports.org (added) Comment: Thanks for the contribution! `port lint` has the following suggestions about your Portfile: {{{ $ port lint ---> Verifying Portfile for mapserver Warning: Line 2 should be a newline (after RCS tag) Warning: Line 3 should be a newline (after PortSystem) Warning: Line 21 has trailing whitespace before newline Warning: Line 33 has trailing whitespace before newline Warning: Line 35 has trailing whitespace before newline Warning: Line 36 has trailing whitespace before newline Warning: Line 37 has trailing whitespace before newline Warning: Line 38 has trailing whitespace before newline Warning: Line 40 has trailing whitespace before newline Warning: Line 41 has trailing whitespace before newline Warning: Line 42 has trailing whitespace before newline Warning: Line 43 has trailing whitespace before newline Error: Unknown category: gis Warning: Variant gdalogr does not have a description Warning: Variant proj does not have a description Warning: Variant wms does not have a description }}} The whitespace notices aren't so important and will probably be removed from `port lint` anyway, but the others are relevant. Variants should have descriptions explaining their use, and we don't have a category "gis". Perhaps the port would fit into one of the existing categories. Further comments from me: * You don't wish to be the maintainer of this port? * It looks like the variant "wms" doesn't do anything so it should be removed. * In the destroot phase you should use `xinstall` instead of `system "install"`. * With regard to your comment on setting the cgi_path, this project is called MacPorts. It hasn't been called DarwinPorts in 16 months. :-) * `extract.suffix .tar.gz` is unnecessary; that's the default. -- Ticket URL: <http://trac.macports.org/ticket/16238#comment:2> MacPorts <http://www.macports.org/> Ports system for Mac OS