#19142: faac doesn't support mp4 ---------------------------------+------------------------------------------ Reporter: anddam@… | Owner: pguyot@… Type: defect | Status: new Priority: Normal | Milestone: Port Bugs Component: ports | Version: 1.7.0 Keywords: faac mp4 support | Port: faac ---------------------------------+------------------------------------------ Comment(by anddam@…): Replying to [comment:1 devans@…]:
--with-mp4v2 means to build the embedded libmp4v2 source and without means to look for an external library
Are you sure? Check [http://trac.macports.org/attachment/ticket/19142/build%20output.txt#L442 this line] from my output, configure script recognizes external library even if '''--with-mp4v2''' [http://trac.macports.org/attachment/ticket/19142/build%20output.txt#L324 was provided to configure].
The submitted patch addresses changes necessary to build against an upgraded version of libmp4v2 (not yet committed) as proposed in #19141 which is not compatible with the current version.
I believe the mp4v2 variant proposed here is unnecessary (mp4 support should be the default) and incorrectly handles configuration using the external library.
I felt it more natural this way, if it is an option in the original package should be a variant. '''easytag''' and '''easytag-devel''' have mp4 variant too.
Patches would continue to be necessary to use the proposed upgraded library because of the change from mp4.h to mp4v2.h. However, a better patch for configure would be to look for either mp4.h or mp4v2.h and configure appropriately.
I'm not sure what you mean, how would you do that?
I would be interested in whether/how the upstream developers intend to support this new version of libmp4v2. As packagers we should probably follow their lead.
I'm dropping a line to them, the project's activity is quiet, at least. Considering that according to files in source tree they are embedding an mp4v2 release from 2004, I think they are not interested in bleeding edge. -- Ticket URL: <http://trac.macports.org/ticket/19142#comment:4> MacPorts <http://www.macports.org/> Ports system for Mac OS