Re: [MacPorts] #46507: QtCurve update with support for Qt5

11 Jan 2015

      #46507: QtCurve update with support for Qt5
--------------------------+---------------------------------
  Reporter:  rjvbertin@…  |      Owner:  macports-tickets@…
      Type:  enhancement  |     Status:  new
  Priority:  Normal       |  Milestone:
 Component:  ports        |    Version:
Resolution:               |   Keywords:  haspatch maintainer
      Port:  QtCurve      |
--------------------------+---------------------------------

Comment (by ryandesign@…):

 You should not set the revision field to a large number like 20150110. The
 revision field is meant to be a small integer, increased whenever a change
 is made to the port that does ''not'' involve a change to the upstream
 code. Since your patch ''does'' involve a change to the upstream code, the
 version field should be changed instead and the revision left at its
 default value of 0.

 In the post-destroot, you have an empty block after an if statement:

 {{{
             if {${subport} eq "qt5-${name}"} {
             } else {
 }}}

 This can be simplified to:

 {{{
             if {${subport} ne "qt5-${name}"} {
 }}}

 You're using `system` procedure to run the `ln` executable to create a
 symlink:

 {{{
                     system "ln -s ${prefix}/lib/kde4/plugins/styles
 ${destroot}${qt_plugins_dir}/"
 }}}

 Instead, please use the MacPorts `ln` procedure:

 {{{
                     ln -s ${prefix}/lib/kde4/plugins/styles
 ${destroot}${qt_plugins_dir}/
 }}}

-- 
Ticket URL: <https://trac.macports.org/ticket/46507#comment:2>
MacPorts <https://www.macports.org/>
Ports system for OS X