#40635: auto-multiple-choice @1.1.1: update to 1.2.1 -----------------------------------+---------------------- Reporter: Joel.Brogniart@… | Owner: devans@… Type: update | Status: assigned Priority: Normal | Milestone: Component: ports | Version: 2.2.0 Resolution: | Keywords: Port: auto-multiple-choice | -----------------------------------+---------------------- Comment (by devans@…): Joel -- Thanks for your submission. A couple of comments: 1) It's very difficult so see what has actually been changed in your proposed patch because of the reformatting. Recommended procedure is to submit actual changes in one patch and reformatting in another to help with this problem. Have attached a revised patch that removes that white space only changes to make it more readable for now. Can add the reformatting in a subsequent patch. 2) You've declared a conflict with port auto-multiple-choice-devel but no such port currently exists. Do you plan to submit one? 3) The post-activate phase using gdk-pixbuf-query-loaders shouldn't be necessary unless this port installs a new gdk-pixbuf loader. I don't see one. 4) I would suggest that, in addition to your own name as maintainer, you add openmaintainer so that other committers can help make updates to the port when you are not available. Is that OK with you? Having said that I have tested the port and it seems to install with no problems other than what I have mentioned above. -- Ticket URL: <https://trac.macports.org/ticket/40635#comment:3> MacPorts <http://www.macports.org/> Ports system for OS X