#38755: port submission: xrmc -------------------------------+-------------------------- Reporter: Tom.Schoonjans@… | Owner: ryandesign@… Type: submission | Status: assigned Priority: Normal | Milestone: Component: ports | Version: 2.1.3 Resolution: | Keywords: Port: xrmc | -------------------------------+-------------------------- Changes (by ryandesign@…): * status: new => assigned * owner: macports-tickets@… => ryandesign@… Comment: We should not use "then" in the "if" statement. "then" is optional in Tcl "if" statements, and I'm not aware of anywhere else in MacPorts where we use it, so for consistency I'd like to not use it here either. Yes, the github portgroup sets defaults for master_sites, among other things. You're of course free to override that as needed. My hope had been that by using the github portgroup you would get a working livecheck for free, however I see now that's not the case, because the developers unfortunately have not created any tags in their repository, so we'll need to fix the livecheck manually. The github portgroup doesn't seem to provide any benefit right at this time, but I'll add it anyway, since it will make it easier to update the port in the event that github makes global changes in their infrastructure, which they have done before. Since the project's github main page contains no information whatsoever, I've changed the homepage to the github wiki page. The license field is not formatted properly; it should be "GPL-3" not "GPLv3". If later versions of the license are also accepted (which based on the comments in the source code files seems to be the case), then it should be "GPL-3+". The checksums do not match. The portfile was attached April 11 and the distfile was last modified April 23. Perhaps the developers performed a [wiki:PortfileRecipes#stealth-updates stealth update]. I hope they are not in the habit of doing that. I can't check to see if the port builds because its dependency xraylib does not build (#39263). I'm attaching my revised portfile. -- Ticket URL: <https://trac.macports.org/ticket/38755#comment:8> MacPorts <http://www.macports.org/> Ports system for OS X