[MacPorts] #35581: kde4 portgroup should not reinplace in binary files

8 Aug 2012

      #35581: kde4 portgroup should not reinplace in binary files
-------------------------------------+--------------------------------------
 Reporter:  ryandesign@…             |       Owner:  macports-tickets@…                   
     Type:  defect                   |      Status:  new                                  
 Priority:  Normal                   |   Milestone:                                       
Component:  ports                    |     Version:  2.1.2                                
 Keywords:                           |        Port:  kde4                                 
-------------------------------------+--------------------------------------
 The kde4-1.1 portgroup has this block:

 {{{

 post-extract {
     # Following the official word: Change #include ["<]Phonon...[">] to
     # ...phonon... in all files that contain that header.
     fs-traverse item ${worksrcpath} {
         if {[file isfile ${item}]} {
             reinplace -locale C "/#include/s@Phonon@phonon@" ${item}
         }
     }
 }
 }}}

 This reinplace will act on ''all'' files, even images and other binary
 files; this is unnecessary, time-wasting, and in a worst case, possibly
 even destructive to those binary files. Could this be changed to only act
 on relevant files? For example, if these #includes would only occur in .h
 files, check that the file name ends in .h before running reinplace.

-- 
Ticket URL: <https://trac.macports.org/ticket/35581>
MacPorts <http://www.macports.org/>
Ports system for Mac OS