#43203: dbus not building on 10.6.8. ‘O_CLOEXEC’ undeclared ------------------------+------------------------ Reporter: gnurser@… | Owner: mcalhoun@… Type: defect | Status: closed Priority: Normal | Milestone: Component: ports | Version: 2.2.1 Resolution: fixed | Keywords: Port: dbus | ------------------------+------------------------ Comment (by rjvbertin@…): Replying to [comment:15 mcalhoun@…]:
For the sake of completeness:
In an attempt to fix a [https://bugs.freedesktop.org/show_bug.cgi?id=72213 bug], the developers of dbus made a [http://cgit.freedesktop.org/dbus/dbus/commit/bus/dir-watch- kqueue.c?id=f4618906b0dce251cdc3125b60239f7dd0df7183 one line change] to the file [http://cgit.freedesktop.org/dbus/dbus/commit/bus/dir-watch- kqueue.c dir-watch-kqueue.c] with the suggestion that _dbus_fd_set_close_on_exec be used if O_CLOEXEC were not available.
r118593 is an attempt to follow that suggestion, but I do not have a test machine.
Any feedback?
Yes, this patch applies to all systems, even those that have O_CLOEXEC, and that's not what's been suggested by the dbus developers. They proposed to test for the presence of O_CLOEXEC in the code, and act accordingly; I'm attaching a modified patch that follows this approach (and that may actually be incorporated into dbus). -- Ticket URL: <https://trac.macports.org/ticket/43203#comment:25> MacPorts <http://www.macports.org/> Ports system for OS X