#17605: pspp-0.6.1 Portfile patch ----------------------------------------+----------------------------------- Reporter: jeremy@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Port Updates Component: ports | Version: 1.6.0 Keywords: portfile update | Port: pspp ----------------------------------------+----------------------------------- Comment(by mcalhoun@…): A few comments on the patch: * Whitespace changes almost always get a separate commit so it is easier to track changes. * If the port is installed without the ncurses variant but with ncursesw installed, won't this be a problem if ncursesw is subsequently uninstalled. This is not a problem with, for example, the graph variant due to --without-libplot. * Setting LD_LIBRARY_PATH is almost never necessary. Why can't psppir be called directly? * I can not remember where I read it, but useful functionality shouldn't be split off into a variant without a compelling reason. Is that the case with pspp? Personally, I have found most variants to be more trouble than they are worth. -- Ticket URL: <http://trac.macports.org/ticket/17605#comment:4> MacPorts <http://www.macports.org/> Ports system for Mac OS