#37737: samscope @1.6.6.91 new port submission -------------------------+-------------------------------- Reporter: krisp@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Resolution: | Keywords: Port: | -------------------------+-------------------------------- Comment (by ryandesign@…): Thanks but I see a number of issues. * the maintainers line should be written in our obfuscated host:user format * indentations should be at multiples of 4 spaces (long_description...) * the distfiles line can be removed; what you've specified is the default * we don't want to fetch a patchfile from your servers (unless it's enormous, which this isn't); we want to include it in the files directory next to the Portfile * the patch should not include the Portfile itself * there should be one patchfile per file being patched, named for the file being patched, or in the case of files being created (setup.py), the file itself should be in the files directory and it should be copied to worksrcpath in a post-extract block * /opt/local should not be hardcoded; arrange for ${prefix} to be used * the version number should appear in the version line of the Portfile only; anywhere else that you need the version number (checksums line?) you would use the ${version} variable; however once the patchfile is included locally, you'll only need to list checksums for the distfile, so you won't need to list any filenames there. * dependencies should be lined up in neat columns like the rest of the file is * since you've specified "use_configure no", you're responsible for ensuring that the [wiki:UsingTheRightCompiler correct compiler] and -arch flags are used -- Ticket URL: <https://trac.macports.org/ticket/37737#comment:1> MacPorts <http://www.macports.org/> Ports system for Mac OS