Re: [MacPorts] #40803: Rsync 3.1.0 released

14 Jun 2014

      #40803: Rsync 3.1.0 released
----------------------+----------------------
  Reporter:  jones@…  |      Owner:  jimjag@…
      Type:  update   |     Status:  new
  Priority:  Normal   |  Milestone:
 Component:  ports    |    Version:
Resolution:           |   Keywords:
      Port:  rsync    |
----------------------+----------------------

Comment (by mojca@…):

 Prerelease version 3.1.1 for rsync are now available for testing. The
 following patch works for me:
 {{{
 #!patch

 --- Portfile    (revision 121017)
 +++ Portfile    (working copy)
 @@ -4,8 +4,7 @@
  PortSystem          1.0

  name                rsync
 -version             3.0.9
 -revision            2
 +version             3.1.1pre2
  categories          net
  license             GPL-3+
  installs_libs       no
 @@ -19,26 +18,15 @@

  homepage            http://samba.org/rsync/
  master_sites        http://rsync.samba.org/ftp/rsync/ \
 -                    http://rsync.samba.org/ftp/rsync/src/
 +                    http://rsync.samba.org/ftp/rsync/src/ \
 +                    http://rsync.samba.org/ftp/rsync/src-previews/

 -checksums           md5     5ee72266fe2c1822333c407e1761b92b \
 -                    sha1    c64c8341984aea647506eb504496999fd968ddfc \
 -                    rmd160  e5ee8d786defb0d8f937c8d027466f418c63c97e \
 -                    sha256
 30f10f8dd5490d28240d4271bb652b1da7a60b22ed2b9ae28090668de9247c05
 +checksums           rmd160  bfeb080eeba2c9bc50f23c56ae38b2f9153d7dc6 \
 +                    sha256
 ea2c20f5a28fb8e75fbee47c0bc68f80ddb3a035e5aabb6c32dbd2090df650d6

  depends_lib         port:popt port:libiconv

 -# these come from http://rsync.samba.org/ftp/rsync/rsync-
 patches-3.0.9.tar.gz
 -# and need to be updated with each release
 -patchfiles          patch-fileflags.diff \
 -                    patch-crtimes.diff \
 -                    patch-hfs-compression.diff \
 -                    patch-hfs-compression-options.diff \
 -                    patch-acls-unpack-error.diff
 -patch.pre_args      -p1
 -
  configure.args      --with-rsyncd-conf=${prefix}/etc/rsyncd.conf
 -configure.cflags   "-Os -I${prefix}/include"

  pre-configure {
      system "cd ${worksrcpath}; ./prepare-source"
 }}}

 I didn't specifically test version 3.1.0 yet (I plan to keep using this
 one for a while), but it would be very nice to get more feedback about
 what exactly is failing in 3.1.0, so that we can report any remaining
 problems and switch to 3.1.0 once it gets released.

 I had to remove
 {{{
 configure.cflags   "-Os -I${prefix}/include"
 }}}
 from the port, otherwise the build fails with:
 {{{
 /usr/bin/clang -I. -I. -pipe -Os -I/opt/local/include -arch x86_64
 -DHAVE_CONFIG_H -Wall -W -I./zlib -I/opt/local/include -c token.c -o
 token.o
 token.c:420:26: error: use of undeclared identifier 'Z_INSERT_ONLY'
                         r = deflate(&tx_strm, Z_INSERT_ONLY);
                                               ^
 1 error generated.
 make: *** [token.o] Error 1
 }}}

 Rsync seems to prefer the modified build-in zlib library. Adding
 `-I/opt/local/include` prevents rsync from finding the files from the
 built-in zlib library because then `-I/opt/local/include` comes in front
 of `-I./zlib`. I reported the problem upstream, asking them to put
 "-I./zlib" in front of `CFLAGS`. But I don't understand the need for
 changing `CFLAGS` in the rsync port anyway.

-- 
Ticket URL: <https://trac.macports.org/ticket/40803#comment:9>
MacPorts <http://www.macports.org/>
Ports system for OS X