#44816: [update] yara 1.4.7 to 1.4.7/3.1.0/devel ------------------------+-------------------------------- Reporter: jul_bsd@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: yara | ------------------------+-------------------------------- Comment (by ryandesign@…): Thanks. Some observations: * When using the github portgroup, the portgroup is expected to take care of all needs regarding master_sites, distname, worksrcdir; you're not expected to need to set them manually. * The dependency on libtool should be written in `port:` style, not `bin:` style; OS X does not come with /usr/bin/glibtool and we would not want a rogue /usr/bin/glibtool installed by the user to satisfy the dependency. * `system`'s `-W` argument should be used instead of running a `cd` command within it. * The python28 variant should be deleted because no such version of python exists. * The python27 variant should only be enabled by default it the user has not already selected another python variant; see PortfileRecipes#default_variants * The python variants should be marked as conflicting with one another. * For the ${name}-devel subport, is fetching from git truly necessary? Fetching from a distfile is preferred, and is the github portgroup's default operating mode. * The livecheck looks like it would only be applicable to one of the subports. (Which one?) Should the other subports get their own livecheck? Note that the github portgroup includes a working default livecheck definition. -- Ticket URL: <https://trac.macports.org/ticket/44816#comment:1> MacPorts <http://www.macports.org/> Ports system for OS X