#46029: port submission: qtchooser --------------------------+-------------------------------- Reporter: rjvbertin@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.3 Resolution: | Keywords: Port: qtchooser | --------------------------+-------------------------------- Comment (by larryv@…): Replying to [comment:12 rjvbertin@…]:
There is no way you can guarantee that the same kind of sneaky change won't happen when using `destroot.destdir`.
And how exactly would that happen? As long as `INSTALL_ROOT` is used, the makefile will behave properly.
Contrary to the changes I'm doing with reinplace, a failing destroot setting has potentially disastrous results because it causes things to get installed somewhere before the actual install phase, and there'd be no warning.
No. The destroot phase is run without superuser privileges. If the makefile changes suddenly stops using `INSTALL_ROOT`, the destroot phase will try to install files outside of the destroot and will fail. (This is one of the reasons we discourage users from setting “macportsuser root” in their macports.conf.)
It's not (just) that I'm confident this won't happen in this particular case, I'm above all confident that I'll catch those changes when they happen.
Okay. I assume you’ll scour the destroot every single time you muck with the port to make sure all the files are always in exactly the right place, then.
The way I see it, this is a decision that's up to the port maintainer to decide what approach to use, but of course others can change things too.
At some level, yes, it is up to the maintainer. Maintainers should write portfiles in a way that makes sense to them. But at another level, you share this project with many other people. When people see a very common task done in an odd way, they think that the normal way wasn’t sufficient for some reason, and that there must be a very good reason for not using it. I frankly don’t see a good reason here. -- Ticket URL: <https://trac.macports.org/ticket/46029#comment:13> MacPorts <https://www.macports.org/> Ports system for OS X