#40631: blockout2 @2.4_0 -------------------------+-------------------------- Reporter: jeremy@… | Owner: ryandesign@… Type: submission | Status: closed Priority: Normal | Milestone: Component: ports | Version: 2.2.0 Resolution: fixed | Keywords: Port: blockout2 | -------------------------+-------------------------- Comment (by ryandesign@…): Replying to [comment:6 jeremy@…]:
I don't know what to do about the universal variant (this is my first MacPorts port) - I was just copying the example Portfile I think.
I already fixed the universal variant in r111727. The key, for build systems like blockout2's that do not regard CFLAGS etc. at configure time, is to manually get the right `-arch` flags and supply them to the build system in the right place. In this port, I chose to add the `-arch` flags to the CC and CXX environment variables, and I got the correct `-arch` flags using the `[get_canonical_archflags]` procedure. This procedure returns the correct `-arch` flags depending on whether the universal variant was selected or not -- but only if a universal variant -- even an empty one -- is defined before it is used. That is why you sometimes see "`variant universal {}`" in some ports, and indeed why it is present and needed in blockout2 now.
Leaving the -Dlinux was an oversight and should be removed (assuming it doesn't break things).
As far as I can tell the build system doesn't use this variable at all so leaving it or taking it out should have no effect, so it's simpler to not change it. -- Ticket URL: <https://trac.macports.org/ticket/40631#comment:8> MacPorts <http://www.macports.org/> Ports system for OS X