#28764: HDRSee portfile -------------------------------+-------------------------------------------- Reporter: pac@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: Keywords: | Port: hdrsee -------------------------------+-------------------------------------------- Changes (by jmr@…): * version: 1.9.2 => * port: => hdrsee Comment: Output of `port lint` on the attachment: {{{ % port lint ---> Verifying Portfile for hdrsee Warning: Line 32 should say "use_configure no" instead of declaring an empty configure phase Error: Missing required variable: platforms Warning: no license set ---> 1 error and 2 warnings found. }}} Additional notes after reviewing the attachment: * Is scons really needed at runtime? If not, it should be in depends_build, not depends_lib. * You shouldn't use arch=nocona unconditionally. Check what arch you are actually building on. * You need to use ${prefix} instead of hardcoding /opt/local in the include and libpath args. * You should not use puts. If you must print a message directly, ui_msg is better, but generally all notes for the user should go in the 'notes' variable. * Users should never have to set DYLD_LIBRARY_PATH. Any program that requires it to be set outside of a testing/debugging environment is linked incorrectly. Sorry it's taken so long for this to be reviewed, but tickets that are not assigned to anyone can easily fall through the cracks. If it appears that a ticket has been forgotten, you can email the macports-dev list. -- Ticket URL: <https://trac.macports.org/ticket/28764#comment:1> MacPorts <http://www.macports.org/> Ports system for Mac OS