#40139: frescobaldi @2.0.10 ------------------------------+-------------------------------- Reporter: davide.liessi@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: frescobaldi | ------------------------------+-------------------------------- Changes (by ryandesign@…): * port: => frescobaldi Comment: Thanks. Some observations: * The standard modeline should be added and the portfile's whitespace should be changed to conform to it (indentations at multiples of 4 spaces) * Variants whose names begin with "no_" are deprecated and should not be added to new ports. Instead use positively-named variants and enable them by default using default_variants. * It's usually insufficient for a variant to merely add or remove a dependency. Usually configure arguments, environment variables or patches have to also be used to ensure that the software does not include support for the given feature in the event that the user has already installed the dependency but not selected the corresponding variant. * Do there actually need to be variants to remove portmidi or py-python- poppler-qt4? Is there any problem with just leaving them enabled all the time and dispensing with the variants? * The python 1.0 portgroup is usually used to build python modules; I'm surprised to see it used here to add python variants to a non-python- module port. Does that actually work? -- Ticket URL: <https://trac.macports.org/ticket/40139#comment:1> MacPorts <http://www.macports.org/> Ports system for OS X