#44526: xxdiff: update to 4.0 --------------------------+-------------------------------- Reporter: rjvbertin@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: xxdiff | --------------------------+-------------------------------- Comment (by rjvbertin@…): Replying to [comment:5 ryandesign@…]:
* One should not both declare "`use_configure no`" and define a "`configure`" block.
OK.
* Do you really need to override the configure phase to run `qmake`? The point of the qmake 1.0 portgroup is to automate that for you.
Have you checked the previous (v3) xxdiff Portfile as well as the port's README.build? A bare-bones qmake won't work.
* One should not "`system "cd ...; ..."`"; one should instead "`system -W ... "..."`".
If you say so ... but I'd prefer to read up on the 'system' documentation before changing something I left unchanged from the v3 xxdiff Portfile (if not only because your suggestion is too ambiguous to my taste; should I understand the syntax is `system -W workDirectory "command args"`?) I'll wait for clarification before uploading a new Portfile diff.
* "`file copy`" can be shortened to "`copy`" and "`file delete`" can be shortened to "`delete`".
OK
* Is there a reason why the documentation needs to be moved to a doc variant? Variants should be added sparingly and when absolutely necessary.
As I tried to indicate, the documentation contains a number of screenshots that take up more space than I considered justified for something I expect no one will ever read. Many ports already provide a +doc variant, I hope exactly to reduce disk space usage. IMHO it's something that should be generalised just like Debian and Ubuntu now split off the documentation of most all packages into separate packages. -- Ticket URL: <https://trac.macports.org/ticket/44526#comment:6> MacPorts <http://www.macports.org/> Ports system for OS X