#16055: TeXworks -- TeX previewer for Mac OS X -- uses the Qt4 GUI framework --------------------------------------+------------------------------------- Reporter: jens.traube@t-online.de | Owner: macports-tickets@lists.macosforge.org Type: enhancement | Status: new Priority: Normal | Milestone: Port Submissions Component: ports | Version: 1.6.0 Resolution: | Keywords: tex, latex, editor, qt4 --------------------------------------+------------------------------------- Comment (by raimue@macports.org): First of all, thanks for your submission of this Portfile. But here are some additional comments and concerns: * Why is the version empty? It should also be tied to a specific svn revision with `svn.tag` * revision should be a positive integer number, default value is 0. The default `revision 0` can be left out. * The homepage should be only one URL (for `port gohome`) * I don't think `svn.pre_args-append` and `svn.post_args-append` are needed * What is the purpose of the post-fetch phase? * Don't use `cd` in the Portfile, it is deprecated and will not work in future versions * Is this code for determining MACOSX_DEPLOYMENT_TARGET really needed? There is already an [option macosx_deployment_target] which contains the right value for the current system. I think it can be reused here. * Wouldn't it be easier to use a patch and a few reinplaces instead of this long post-patch phase? * There should be no need to use system to copy the TexWorks.app, you can use `file copy` * Please file a separate ticket for the wrong paths in the pkg-config files for qt4-mac as this needs to be fixed. Would be good to add a ticket number for reference so this workaround can be removed once it is fixed. -- Ticket URL: <http://trac.macports.org/ticket/16055#comment:4> MacPorts <http://www.macports.org/> Ports system for Mac OS