#28611: mspgcc4 port submission ----------------------------+----------------------------------------------- Reporter: nf6x@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 1.9.2 Keywords: mspgcc4 MSP430 | Port: mspgcc4 ----------------------------+----------------------------------------------- Changes (by ryandesign@…): * cc: nf6x@… (removed) * cc: ryandesign@… (added) Comment: Ok, my feedback: * Remove the library dependency on port:wget, unless this software really does use wget at runtime. If you only added it because you call wget during post-fetch, then a) it should have been depends_fetch not depends_lib, b) it should have been curl not wget since curl is standard on Mac OS X but wget is not, and c) see below. * Don't fetch distfiles manually in post-fetch; add these files to distfiles so they're cached locally and mirrored by our distfiles network. The problem here is that the port fetches via git and MacPorts only does a single fetch type per port. If possible, switch to fetching the port's main software via a regular distfile instead of git. If no regular distfile is available and git is the only method, then do the git fetch in post-fetch, since we don't cache that anyway (see #16373). * Is it necessary to violate the mtree, or could the software be placed somewhere that doesn't violate, like ${prefix}/libexec/${name} or ${prefix}/share/${name} (depending on whether it's architecture-specific or architecture-independent files, respectively)? There's no need for ${version} to appear in the installed location, unless we're going to have multiple ports for multiple versions of this software. * There's no need to "file mkdir ${destroot}${prefix}/bin" in destroot; MacPorts creates that directory for you. * Are we UsingTheRightCompiler and obeying build_arch and supporting universal builds? * Use native tcl commands (glob and ln -s) instead of system to create the symlinks in post-destroot. -- Ticket URL: <https://trac.macports.org/ticket/28611#comment:2> MacPorts <http://www.macports.org/> Ports system for Mac OS