#42776: NEW: hplip @3.14.1 ---------------------------+-------------------------------- Reporter: okmacports@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: hplip | ---------------------------+-------------------------------- Changes (by ryandesign@…): * cc: ryandesign@… (added) Comment: Thanks. Sorry this port has taken so long. I have some comments on this submission: * master_sites should be written to [wiki:howto/AvoidRedirects avoid redirects]. * You needn’t use quotes around arguments when using configure.env- append, configure.cppflags-append, configure.cflags-append, etc. * You don’t need “--prefix=${prefix}” in configure.args because MacPorts already puts it in configure.pre_args for you. * The reinplaces in pre-configure are usually done in post-patch. However, there are rather a lot of them, and it would be difficult for an outsider to evaluate, years from now, after new versions of the software have been released, whether they are all still needed or still functioning correctly. Therefore we usually use patch files, not just reinplaces. * installer-dcheck.py.patch hardcodes the path /opt/local. MacPorts could be installed in a different prefix. You must arrange to use the value of the MacPorts variable ${prefix} instead of hardcoding it. For example, many ports write “@PREFIX@” into the patch file, then use reinplace in the Portfile in a post-patch block to replace “@PREFIX@” with “${prefix}”. * Please remove the lines of “#” characters from the beginning and end of the notes. Just put the text of your note. If you believe MacPorts does not display port notes prominently enough, then surely that’s a problem that would affect all ports, not just hplip, and should be solved in MacPorts base, not in each individual Portfile. * Portfile indentation should be consistent. Currently some indents are 4 spaces and others are 8 spaces. 4 spaces is the MacPorts standard indentation style. -- Ticket URL: <https://trac.macports.org/ticket/42776#comment:2> MacPorts <http://www.macports.org/> Ports system for OS X